[WIP] UI Design Stage2 #42
Conversation
|
Huh, interesting! Can you elaborate - you said you can't pass it, but when you try what happens? Thanks! |
|
Could a unit test be written against this intended functionality, to show the error? |
|
Hi, @IshaGupta18 -- thanks! Would you mind trying to push this to your github pages branch, along with your dependencies, so we can try it out? You'll need to make a |
|
Oh i missed your last comment. Checking now at #45 |
| value: function handleFileSelectremote(val) { | ||
| var proxyurl = "https://cors-anywhere.herokuapp.com/"; | ||
| var url = val; | ||
| fetch(proxyurl + url).then(function (response) { |
There was a problem hiding this comment.
Aha, is it on these lines that the error is occurring? Maybe with input from this comment you can output the complete error?
| return response.text(); | ||
| }).then(function (contents) { | ||
| return console.log(contents); | ||
| })["catch"](function () { |
There was a problem hiding this comment.
I'm not completely familiar with this syntax but i think it might be:
| })["catch"](function () { | |
| })["catch"](function (e) { | |
| console.log('error!', e); |
There was a problem hiding this comment.
@jywarren I think this should be automatically incorporated once @IshaGupta18 passes the error object below (as I suggested) since the dist is built from that?
simple-data-grapher/src/View.js
Line 127 in 46ff3bd
Okay so this is the correct way of doing the job @namangupta01 thank you for correcting me!
@jywarren kindly have a look at this one!
I have tried to develop a workaround for fetching CSV data from a remote file, without getting the CORS (#35). It works well, however I am not able to pass the fetched data to another function, but I am able to print it at the console.
Also, I am facing the same bug I was facing here #39
@namangupta01 @IgorWilbert @gauravano @Souravirus I would really appreciate if you could help me debug here so that this PR is merged ASAP. Thanks a lot!