Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow failure: Update bridge, ecosystem providers #566

Closed
26 of 28 tasks
pulumi-bot opened this issue Sep 12, 2023 · 8 comments · Fixed by #603
Closed
26 of 28 tasks

Workflow failure: Update bridge, ecosystem providers #566

pulumi-bot opened this issue Sep 12, 2023 · 8 comments · Fixed by #603
Assignees
Labels
kind/engineering Work that is not visible to an external user p1 A bug severe enough to be the next item assigned to an engineer resolution/fixed This issue was fixed
Milestone

Comments

@pulumi-bot
Copy link

pulumi-bot commented Sep 12, 2023

Workflow Failure

Update bridge, ecosystem providers has failed. See the list of failures below:

Ensure that every provider updated to p/p 3.81.0 and bridge 3.59.0.

Bridged Providers

Tier 1 - all upgraded

  • aws
  • gcp
  • azure
  • azuread

Tier 2 - not upgraded yet

Used a script to detect remaining here they are:

  • akamai github.com/pulumi/pulumi/pkg/v3 v3.81.0
  • archive github.com/pulumi/pulumi/pkg/v3 v3.81.0 // indirect
  • azuredevops github.com/pulumi/pulumi/pkg/v3 v3.81.0 // indirect
  • cloudflare github.com/pulumi/pulumi/pkg/v3 v3.81.0 // indirect
  • cloudinit github.com/pulumi/pulumi/pkg/v3 v3.81.0 // indirect
  • confluentcloud github.com/pulumi/pulumi/pkg/v3 v3.81.0 // indirect
  • datadog github.com/pulumi/pulumi/pkg/v3 v3.81.0 // indirect
  • dnsimple github.com/pulumi/pulumi/pkg/v3 v3.60.0 // indirect
  • ec github.com/pulumi/pulumi/pkg/v3 v3.81.0 // indirect
  • external github.com/pulumi/pulumi/pkg/v3 v3.84.0 // indirect
  • gitlab github.com/pulumi/pulumi/pkg/v3 v3.81.0 // indirect
  • hcloud github.com/pulumi/pulumi/pkg/v3 v3.81.0 // indirect
  • http github.com/pulumi/pulumi/pkg/v3 v3.81.0 // indirect
  • keycloak github.com/pulumi/pulumi/pkg/v3 v3.81.0 // indirect
  • kong github.com/pulumi/pulumi/pkg/v3 v3.81.0 // indirect
  • linode github.com/pulumi/pulumi/pkg/v3 v3.81.0 // indirect
  • local github.com/pulumi/pulumi/pkg/v3 v3.81.0 // indirect
  • null github.com/pulumi/pulumi/pkg/v3 v3.81.0 // indirect
  • oci github.com/pulumi/pulumi/pkg/v3 v3.81.0 // indirect
  • openstack github.com/pulumi/pulumi/pkg/v3 v3.81.0 // indirect
  • random github.com/pulumi/pulumi/pkg/v3 v3.81.0 // indirect
  • slack github.com/pulumi/pulumi/pkg/v3 v3.81.0 // indirect
  • tls github.com/pulumi/pulumi/pkg/v3 v3.82.1 // indirect
  • vault github.com/pulumi/pulumi/pkg/v3 v3.40.2 // indirect
@pulumi-bot pulumi-bot added kind/engineering Work that is not visible to an external user needs-triage Needs attention from the triage team p1 A bug severe enough to be the next item assigned to an engineer labels Sep 12, 2023
@mikhailshilkov mikhailshilkov removed the needs-triage Needs attention from the triage team label Sep 14, 2023
@mikhailshilkov mikhailshilkov added this to the 0.94 milestone Sep 14, 2023
@t0yv0
Copy link
Member

t0yv0 commented Sep 14, 2023

Driving by here @guineveresaenger since this is now on my critical path. Per our convo I'll check in on these:

  • random
  • tls
  • vault
  • gcp

@t0yv0
Copy link
Member

t0yv0 commented Sep 14, 2023

gcp is done by hand pulumi/pulumi-gcp@58a53ad

@t0yv0
Copy link
Member

t0yv0 commented Sep 14, 2023

aws got done by Ian.

@t0yv0
Copy link
Member

t0yv0 commented Sep 14, 2023

import requests

plist = [
    'akamai',
    'archive',
    'azuredevops',
    'cloudflare',
    'cloudinit',
    'confluentcloud',
    'datadog',
    'dnsimple',
    'ec',
    'equinix',
    'external',
    'gitlab',
    'hcloud',
    'http',
    'keycloak',
    'kong',
    'linode',
    'local',
    'null',
    'oci',
    'openstack',
    'random',
    'slack',
    'tls',
    'vault',
]

providers = [

    'aiven',
    'akamai',
    'alicloud',
    'archive',
    'artifactory',
    'auth0',
    'azuredevops',
    'civo',
    'cloudamqp',
    'cloudflare',
    'cloudinit',
    'confluentcloud',
    'consul',
    'databricks',
    'datadog',
    'digitalocean',
    'dnsimple',
    'docker',
    'ec',
    'equinix-metal',
    'external',
    'f5bigip',
    'fastly',
    'github',
    'gitlab',
    'hcloud',
    'http',
    'kafka',
    'keycloak',
    'kong',
    'libvirt',
    'linode',
    'local',
    'mailgun',
    'minio',
    'mongodbatlas',
    'mysql',
    'newrelic',
    'nomad',
    'ns1',
    'null',
    'oci',
    'okta',
    'onelogin',
    'openstack',
    'opsgenie',
    'pagerduty',
    'postgresql',
    'rabbitmq',
    'rancher2',
    'random',
    'rke',
    'signalfx',
    'slack',
    'snowflake',
    'splunk',
    'spotinst',
    'sumologic',
    'tailscale',
    'tls',
    'vault',
    'venafi',
    'vsphere',
    'wavefront',
]

for provider in providers:
    resp = requests.get(f"https://raw.githubusercontent.com/pulumi/pulumi-{provider}/master/provider/go.mod")
    for line in resp.text.split('\n'):
        if 'github.com/pulumi/pulumi/pkg' in line:
            if ('3.81.0' not in line) and ('3.82.1' not in line):
                print("- [ ]", provider, line)
            elif provider in plist:
                print("- [x]", provider, line)

@guineveresaenger
Copy link
Contributor

Here's the current status summary:

EXTEMPORAL UPDATE ON PROVIDER P1s:
Still open

  • pulumi-archive: SchemaOnlyProvider
  • external SchemaOnlyProvider
  • http SchemaOnlyProvider
  • local SchemaOnlyProvider
  • null SchemaOnlyProvider
  • pulumi-confluentcloud: actions out of sync
  • cloudinit Failed to find docs for resource
  • dnsimple Failed to find docs for resource
  • gitlab Workflows not upgraded; tool looked for wrong reviewer team. Bridge is updated
  • [openstack](Workflow failure: Upgrade bridge pulumi-openstack#380: Workflows not upgraded; tool looked for wrong reviewer team
  • equinix-metal Planning Plugin SDK failure: Did not recognize branch
  • kong Planning Plugin SDK failure: Did not recognize branch
  • vault blocked on the usual spurious azure dependency
  • hcloud - Workflow succeeded but PR failed in CI P1 resolved but needs followup
  • keycloak Workflow succeeded but PR failed in CI P1 resolved but needs followup
  • oci git identity issue on runner, rerun is triggered
  • Slack - this PR failed on lint and needed a rebase. P1 resolved but needs followup

@t0yv0
Copy link
Member

t0yv0 commented Sep 20, 2023

I've updated the list. This is better. I'm going to take a stab at updating http and external after a bridge release that gets us past pulumi/pulumi-terraform-bridge#1379

@t0yv0
Copy link
Member

t0yv0 commented Sep 20, 2023

Two left..

@guineveresaenger
Copy link
Contributor

Also need to address #593. Going to look at a fix for that next

guineveresaenger added a commit that referenced this issue Sep 21, 2023
Previous to this change, when the `upgrade-on-main` step failed, we
would call `upgrade-on-master` every time, because the `if` condition on
that step never made sense.
But for providers where default branch is set to `main`, this would
result in an overall failure, because `upgrade-on-master` does not
specify `continue-on-error: true`.
With this change, the `upgrade-on-master` step should no longer run at
all for providers whose default branch is `main`.

Note that using `github.event.repository.default_branch` is not
available to us here, as that would detect the originating repo's
(ci-mgmt's) default branch.

Furthermore, this PR adds a Workflow to update a single ecosystem
provider, so we can optionally do gradual/test rollouts of updates.

Final note: There are a lot of "bridge updates" in this folder, and some
are stale. To keep the scope tight, this is tracked in
#579.

Closes #566.
Closes #593.
- fix success logic on triggering against master ref
- Add option to upgrade a single provider's bridge version
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/engineering Work that is not visible to an external user p1 A bug severe enough to be the next item assigned to an engineer resolution/fixed This issue was fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants