Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate "Update bridge, all providers" and "Update bridge, single providers" Workflows #579

Closed
guineveresaenger opened this issue Sep 15, 2023 · 1 comment · Fixed by #780
Closed

Deprecate "Update bridge, all providers" and "Update bridge, single providers" Workflows #579

guineveresaenger opened this issue Sep 15, 2023 · 1 comment · Fixed by #780
Assignees
@iwahbe
Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed

Comments

@guineveresaenger
Copy link
Contributor

guineveresaenger commented Sep 15, 2023 •
edited
Loading

These are no longer used, in favor of "Update bridge, ecosystem providers"
"All providers" was run last year: https://github.com/pulumi/ci-mgmt/actions/workflows/update-bridge-all-providers.yml
"Single provider" was run 7 months ago

As part of this work, we should also remove the "Update bridge" Workflows in provider repos.
https://github.com/pulumi/pulumi-hcloud/actions/workflows/update-bridge.yml
@mikhailshilkov mikhailshilkov added the kind/engineering Work that is not visible to an external user label Sep 16, 2023
@guineveresaenger guineveresaenger mentioned this issue Sep 21, 2023
Merged
guineveresaenger added a commit that referenced this issue Sep 21, 2023
@guineveresaenger
Fix default branch logic for Workflow dispatch of bridge upgrade (#603)
72eb690 
Previous to this change, when the `upgrade-on-main` step failed, we
would call `upgrade-on-master` every time, because the `if` condition on
that step never made sense.
But for providers where default branch is set to `main`, this would
result in an overall failure, because `upgrade-on-master` does not
specify `continue-on-error: true`.
With this change, the `upgrade-on-master` step should no longer run at
all for providers whose default branch is `main`.

Note that using `github.event.repository.default_branch` is not
available to us here, as that would detect the originating repo's
(ci-mgmt's) default branch.

Furthermore, this PR adds a Workflow to update a single ecosystem
provider, so we can optionally do gradual/test rollouts of updates.

Final note: There are a lot of "bridge updates" in this folder, and some
are stale. To keep the scope tight, this is tracked in
#579.

Closes #566.
Closes #593.
- fix success logic on triggering against master ref
- Add option to upgrade a single provider's bridge version
@iwahbe iwahbe self-assigned this Jan 14, 2024
@iwahbe iwahbe mentioned this issue Jan 14, 2024
Merged
@iwahbe
Copy link
Member

iwahbe commented Jan 14, 2024

As part of this work, we should also remove the "Update bridge" Workflows in provider repos.
https://github.com/pulumi/pulumi-hcloud/actions/workflows/update-bridge.yml

I believe that we have already removed this workflow from our providers.

iwahbe added a commit that referenced this issue Jan 16, 2024
@iwahbe
Remove unneeded GH Workflows (#780)
288d006 
- `.github/workflows/update-bridge-all-providers.yml` has never run.
- `.github/workflows/update-bridge-single-provider.yml` has not run in
the last year.
- `.github/workflows/update-gh-branch-protection.yml` it not necessary
since we have added Deployments to this repo.

Fixes #579
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iwahbe iwahbe

Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unneeded GH Workflows pulumi/ci-mgmt
4 participants
@mikhailshilkov @guineveresaenger @iwahbe @pulumi-bot