Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider adding support for Diff #433

Open
Tracked by #449
thomas11 opened this issue May 14, 2024 · 1 comment
Open
Tracked by #449

Consider adding support for Diff #433

thomas11 opened this issue May 14, 2024 · 1 comment
Labels
kind/enhancement Improvements or new features

Comments

@thomas11
Copy link
Contributor

thomas11 commented May 14, 2024 •
edited
Loading

The Diff operation is defined in the Pulumi resource model.

The Diff method is responsible for calculating the differences between the actual and desired state of a resource as represented by its last recorded state and new input Object as returned from Check or Read and the logical operation necessary to reconcile the two (i.e. no operation, an Update, or a Replace).

Allowing users to define a specific command to run on Diff could open up new use cases. If you have such a case, please comment below!

This issue is a follow-up from #20.
@thomas11 thomas11 added the kind/enhancement Improvements or new features label May 14, 2024
@thomas11 thomas11 mentioned this issue May 14, 2024
Closed
@lukehoban lukehoban mentioned this issue May 18, 2024
Closed
12 tasks
@danielrbradley
Copy link
Member

I think this is the same as #49 - perhaps we just need a "preview" command which allows the provider to generate the diff.

@stooj stooj mentioned this issue Jul 11, 2024
Merged
thomas11 pushed a commit that referenced this issue Jul 15, 2024
@stooj
fix(docs): Update README to include implemented update command (#492)
8928e7f 
The README points to #20
and says `Update` isn't implemented.

[Diff](#433) and
[Read](#432) are still
not done, but [Update is
implemented](https://github.com/pulumi/pulumi-command/blob/e7e39fd913708c3e5255d8399c87a736553fec43/sdk/python/pulumi_command/remote/command.py#L196)

The example code could be updated (hah!) to include an `update` (maybe
with Luke's `color`/`description` example), but this PR just removes
information that misled me.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Improvements or new features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thomas11 @danielrbradley