-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading go version from 1.17 to 1.18.3 #96
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Looks good to me! Looks like tests are failing, however. Not sure what's going on there.
@RobbieMcKinstry tests are failing as they are missing PULUMI_ACCESS_TOKEN
this is not related to the change I made |
Yes, I agree, it's very plausible that the failing builds are unrelated to the changes you made. However, I'd like to get a better idea of why they're failing before merging since we don't want to break the build on the default branch. |
@mikolajprzybysz would it be okay with you if I closed this PR in lieu of #97 ? My understanding is that Secrets are not accessible to PRs from forked repositories. If that's truly the case, I'm not sure how we haven't encountered this sooner. I'm going to open an issue to inspect and address. In the meantime, we can get your changes in by using a branch PR instead of a fork PR, if that's okay with you! :) |
@RobbieMcKinstry fine by me! I am for anything that helps merge this change in :) |
Thanks very much for understanding! I opened #98 to track the cause of the failed CI checks. :) |
@RobbieMcKinstry could you release it as new version as well, I would like to use it to update pulumi-kubernetes-operator as well |
Hi again! I see that the release process for this repo is a little different from our other repos. Let me check with the team and get back to you :) |
Hey there @mikolajprzybysz ! Today I learned that this repository is released in lock-step with the That is to say, you can expect this PR to make its way into |
@RobbieMcKinstry thank you so much for the clarification, that's all I need to know! |
This PR bumps following images:
go/Dockerfile
,go/Dockerfile.ubi
andpulumi/Dockerfile
which build successfully,along go version upgrade in .github workflow
https://tip.golang.org/doc/go1.18#:~:text=Go%201.18%20includes%20an%20implementation,compatible%20%2D%20changes%20to%20the%20language.