-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service account import issues #1375
Comments
This should be fixed as of pulumi-terraform-bridge v3.72.0, which will go out bundled in this week's gcp release. pulumi/pulumi-terraform-bridge#1629 addresses this specifically. Here is a registry preview of the changes Because registry site previews don't persist, here's a screenshot: This might be good enough to close this issue although of course it would be a nice refinement to ensure we add some newlines. |
Let's take the opportunity to get the newline insertion working. This is taken from http://registry--origin-pr-3880-8a2862d0.s3-website.us-west-2.amazonaws.com/registry/packages/gcp/api-docs/certificatemanager/certificatemap/#gcp-certificatemanager-certificatemap: There is a pretty big readability improvement going from ☝️ to 👇.
|
This PR allows docsgen to retain newlines in import sections by adding a double newline placeholder to the end of every line in the `Import` section of the docs. Previously, newlines were not honored except around the import code part itself. Tests are adjusted to reflect newlines being appended rather than prepended. [Here is a registry preview](http://registry--origin-pr-3897-6eedfa57.s3-website.us-west-2.amazonaws.com/registry/packages/gcp/api-docs/certificatemanager/certificatemap/) Screenshot from that preview: <img width="768" alt="Screenshot 2024-02-02 at 5 33 14 PM" src="https://github.com/pulumi/pulumi-terraform-bridge/assets/13116240/80c61703-9f88-424d-bd56-50829a2c46e9"> Closes pulumi/pulumi-gcp#1375.
What happened?
Part user issue from slack, part just my observations.
User was trying to import a service account with:
pulumi import gcp:serviceaccount/account:Account default projects/****/serviceAccounts/**@**.iam.gserviceaccount.com
but got an error:When I went to look at the docs for this I noticed the import docs where a mess, including broken markdown from Terraform docs about import blocks.
Example
pulumi import gcp:serviceaccount/account:Account default projects/****/serviceAccounts/**@**.iam.gserviceaccount.com
Output of
pulumi about
N/A
Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
The text was updated successfully, but these errors were encountered: