Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Epic] API Docs Q3/Q4 Improvements #3780

Closed
21 of 43 tasks
cnunciato opened this issue Jan 18, 2024 · 10 comments
Closed
21 of 43 tasks

[Epic] API Docs Q3/Q4 Improvements #3780

cnunciato opened this issue Jan 18, 2024 · 10 comments
Assignees
Labels
area/api-docs Generated API docs, generated from providers. For hand-written docs, see area/docs. kind/epic Large new features or investments needs-triage Needs attention from the triage team resolution/fixed This issue was fixed

Comments

@cnunciato
Copy link
Contributor

cnunciato commented Jan 18, 2024

This issue tracks the work we'll be doing in Q3 and Q4 to improve our API docs-generation processes, content quality, and overall user experience.

Project doc: https://docs.google.com/document/d/181uKD8zfVF3m_VkehQdhPYQ88r9AGog5X7wHjXo6_YY/edit

Q3: Providers team

  1. kind/engineering resolution/fixed
    t0yv0
  2. area/docsgen kind/bug p1 resolution/fixed
    t0yv0
  3. area/docs kind/bug resolution/fixed
    guineveresaenger

Q3: Core team

  1. area/codegen kind/enhancement
  2. kind/bug resolution/fixed
    Zaid-Ajaj
  3. area/docs kind/enhancement resolution/fixed
    Zaid-Ajaj sean1588

Q3: Docs team

  1. area/codegen area/docs customer/lighthouse kind/bug resolution/fixed size/M
    sean1588
  2. 2 of 7
    kind/engineering size/L
  3. area/docs kind/enhancement resolution/fixed
    Zaid-Ajaj sean1588
  4. area/docs kind/enhancement resolution/fixed size/M
    sean1588
  5. 8 of 8
    area/api-docs kind/engineering resolution/fixed size/S
    cnunciato
  6. 4 of 7
  7. area/docs kind/codegen resolution/fixed
    cnunciato
  8. area/api-docs kind/enhancement
  9. area/docs kind/enhancement

Q4: Core team

Q4: Docs team

Q4: Providers team

  1. area/docs kind/bug
  2. area/docsgen kind/bug resolution/fixed
    guineveresaenger
  3. area/docsgen kind/bug resolution/fixed
    guineveresaenger
  4. area/docsgen kind/bug resolution/fixed
    iwahbe
  5. area/docsgen kind/bug
    sean1588
  6. area/api-docs area/providers kind/enhancement resolution/fixed size/L
    guineveresaenger
  7. area/docs kind/bug
    guineveresaenger
  8. area/docsgen kind/bug resolution/fixed
    guineveresaenger
  9. area/docs kind/bug resolution/fixed
    guineveresaenger
  10. area/docs kind/bug resolution/fixed
    guineveresaenger

Out of scope

  1. area/docsgen kind/epic resolution/duplicate
    guineveresaenger
  2. area/docsgen kind/epic resolution/duplicate
    guineveresaenger
@github-actions github-actions bot added the needs-triage Needs attention from the triage team label Jan 18, 2024
@github-project-automation github-project-automation bot moved this to 🤔 Triage in Docs 📚 Jan 18, 2024
@cnunciato cnunciato moved this from 🤔 Triage to 🔧 In Progress in Docs 📚 Jan 18, 2024
@cnunciato cnunciato added kind/epic Large new features or investments area/api-docs Generated API docs, generated from providers. For hand-written docs, see area/docs. and removed needs-triage Needs attention from the triage team labels Jan 18, 2024
@iwahbe
Copy link
Member

iwahbe commented Jan 18, 2024

On the providers list is: Add variable declarations for undefined references in bridged provider examples. I'm not 100% sure where this work should go, but my intuition is that we want these kind of transforms to happen at the PCL level, which implies the work item should be moved to the IaC Core team.

CC @justinvp @Zaid-Ajaj

@iwahbe
Copy link
Member

iwahbe commented Jan 19, 2024

We discussed implementing Enable documentation of provider overlays at the regestrygen level, not as part of individual providers. If this is done by providers, we will need schema support, since that is the only artifact we emit for docs generation.
CC @cnunciato

@iwahbe
Copy link
Member

iwahbe commented Jan 19, 2024

  • Add and populate a new field to the schema for copyable resource constructors
  • Add and populate a new field to the schema for copyable lookup functions

Why do these need to be new schema fields? I thought the plan was that docsgen derived these from the existing schema.

@justinvp
Copy link
Member

  • Explore/spike on generating copyable resource constructors (minimal and complete)
  • Explore/spike on generating copyable lookup functions

I think both of these are covered by pulumi/pulumi#14675

@justinvp
Copy link
Member

  • Add and populate a new field to the schema for copyable resource constructors
  • Add and populate a new field to the schema for copyable lookup functions

Why do these need to be new schema fields? I thought the plan was that docsgen derived these from the existing schema.

Yeah, I don't expect we need anything new in the schema for these.

@iwahbe
Copy link
Member

iwahbe commented Jan 19, 2024

@cnunciato @justinvp I have edited the issue lists to move some items to their appropriate teams. That was mostly moving items from the Providers team to the IaC Core team.

@cnunciato cnunciato moved this from 🔧 In Progress to 🤯 Epics in Docs 📚 Jan 23, 2024
@cnunciato cnunciato added this to the 0.99 milestone Jan 23, 2024
@interurban interurban modified the milestones: 0.99, 0.100 Jan 30, 2024
@lukehoban
Copy link
Member

Let's pull the items in pulumi/pulumi-terraform-bridge#1291 into this Epic (identifying which layer of the stack each need to be fixed).

@iwahbe
Copy link
Member

iwahbe commented Feb 12, 2024

Let's pull the items in pulumi/pulumi-terraform-bridge#1291 into this Epic (identifying which layer of the stack each need to be fixed).

That issue tracks formatting issues introduced by the bridge scraping process, so the bridge's docs generation is the layer of the stack where each of these bugs should be fixed.

@interurban interurban modified the milestones: 0.102, 0.104 May 10, 2024
@interurban interurban modified the milestones: 0.104, 0.105 May 22, 2024
@interurban interurban modified the milestones: 0.105, 0.106 Jun 11, 2024
@cnunciato cnunciato modified the milestones: 0.106, 0.107 Jul 1, 2024
@cnunciato
Copy link
Contributor Author

Closing this out as we're no longer working this epic, but leaving remaining issues open to be picked up later.

@github-project-automation github-project-automation bot moved this from 🤯 Epics to 🏁 Done in Docs 📚 Jul 23, 2024
@pulumi-bot pulumi-bot reopened this Jul 23, 2024
@pulumi-bot
Copy link
Collaborator

Cannot close issue:

  • does not have required labels: resolution/

Please fix these problems and try again.

@cnunciato cnunciato added the resolution/fixed This issue was fixed label Jul 23, 2024
@github-actions github-actions bot added the needs-triage Needs attention from the triage team label Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api-docs Generated API docs, generated from providers. For hand-written docs, see area/docs. kind/epic Large new features or investments needs-triage Needs attention from the triage team resolution/fixed This issue was fixed
Projects
Status: 🏁 Done
Development

No branches or pull requests

7 participants