Handle errors during ReadDataApply

[adrien-f]

As seen in the Protobuf, ReadDataSource_Response can contain diagnostics errors.

[VenelinMartinov]

Hi @adrien-f, thanks for contributing.

The change looks sensible but I am wondering if you are using this code and what your use case here is?

I am not aware of any uses of it in pulumi - we have a better supported way of bridging providers. Was that insufficient for your use case or is there some other limitation I am not aware of?

[adrien-f]

Hey @VenelinMartinov !

I can understand this PR coming out of nowhere 😅 I was playing around the tfshim library to learn how it works and ran into this issue on my way.

[VenelinMartinov]

@adrien-f that's great, glad you are finding it interesting and hope you haven't hit too many issues!

The tfplugin5 interface is a bit abandoned since it isn't really used internally - most of our providers are using the sdkv2 interface:

pulumi-terraform-bridge/pkg/tfshim/sdk-v2/provider.go

Line 61 in 18db7c5

func NewProvider(p *schema.Provider, opts ...providerOption) shim.Provider {

There's also the pf bridge which is somewhat separate - it acts on the v6 version of the TF protocol:

pulumi-terraform-bridge/pf/tfbridge/provider.go

Line 48 in 18db7c5

type provider struct {

(ex https://github.com/pulumi/pulumi-random)

[adrien-f]

Many thanks for the pointers 👀

[mjeffryes]

we might be able to get rid of tfshim/tfplugin5. Might be worth soliciting for community feedback to find out if anyone is using it or if we could just drop it with no impact.

[guineveresaenger]

Hi @adrien-f - thanks again for bringing this to our attention.

We have decided to deprecate this particular implementation of tfplugin via #2197.

Thank you for making us aware.