Acceptance tests do not run on community PRs #2179
Assignees
Labels
Comments
VenelinMartinov
added
the
kind/engineering
iwahbe
added
the
p1
iwahbe
added a commit
that referenced
this issue
Jul 19, 2024
Community contributors don't have access to either of these tokens and we don't *need* them to run tests for them, so we make them optional. This should enable Pulumi Org members to approve CI runs for contributors. Fixes #2179
iwahbe
added a commit
that referenced
this issue
Jul 19, 2024
Community contributors don't have access to either of these tokens and we don't *need* them to run tests for them, so we make them optional. This should enable Pulumi Org members to approve CI runs for contributors. Fixes #2179
|
This issue has been addressed in PR #2209 and shipped in release v3.88.0. |
|
This seems to still be an issue: pulumi/pulumi-dnsimple#467 |
VenelinMartinov
added
resolution/fixed
|
The /run-acceptance-tests comment actually worked but it took a while: https://github.com/pulumi/pulumi-dnsimple/actions/runs/10142262748 but the "approve tests" didn't. Sorry for the noise, I was a bit hasty here. |
|
We still can't merge community PRs, reopening this. |
VenelinMartinov
removed
p1
|
The acceptance test ran but the PR is still not mergable: pulumi/pulumi-dnsimple#467 |
|
@VenelinMartinov This issue AFAIK only applied to the bridge, not to our providers. CI for providers is managed in pulumi/ci-mgmt. If we have the same problem in a provider, please open another issue in ci-mgmt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened?
#2174
Acceptance tests do not seem to run on community PRs even after member approval.
Example
.
Output of
pulumi about.
Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
The text was updated successfully, but these errors were encountered: