Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PULUMI_BOT_TOKEN and CODECOV_TOKEN optional #2209

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Jul 19, 2024

Community contributors don't have access to either of these tokens and we don't need them to run tests for them, so we make them optional. This should enable Pulumi Org members to approve CI runs for contributors.

Fixes #2179

@iwahbe iwahbe self-assigned this Jul 19, 2024
@iwahbe iwahbe requested a review from a team July 19, 2024 20:34
Community contributors don't have access to either of these tokens and we don't *need*
them to run tests for them, so we make them optional. This should enable Pulumi Org
members to approve CI runs for contributors.

Fixes #2179
@iwahbe iwahbe force-pushed the iwahbe/enable-community-contributions-ci branch from e2a6f85 to ef49207 Compare July 19, 2024 20:37
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.62%. Comparing base (45e5bcc) to head (ef49207).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2209   +/-   ##
=======================================
  Coverage   60.62%   60.62%           
=======================================
  Files         355      355           
  Lines       46311    46311           
=======================================
  Hits        28076    28076           
+ Misses      16678    16677    -1     
- Partials     1557     1558    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iwahbe iwahbe merged commit 35af14c into master Jul 19, 2024
11 checks passed
@iwahbe iwahbe deleted the iwahbe/enable-community-contributions-ci branch July 19, 2024 21:10
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v3.88.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Acceptance tests do not run on community PRs
3 participants