Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GITHUB_TOKEN in curl requests, run generate-go-mod.sh #495

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

cnunciato
Copy link
Member

@cnunciato cnunciato commented Jan 12, 2023

Running this script without a GITHUB_TOKEN occasionally yields null values in go.mod files because of GitHub rate limiting. This change adds the ambient GITHUB_TOKEN to curl request headers and re-runs the script to regenerate updated values.

Also "downgrades" github-go to v4 while we sort out what's going on with #481.

Copy link
Contributor

@scottslowe scottslowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. At some point (not as part of this PR), we need to think about updating the Go version for all these templates.

@cnunciato cnunciato force-pushed the cnunciato/pass-gh-token branch 2 times, most recently from 5d8290d to 960387d Compare January 12, 2023 20:56
@@ -1,7 +1,7 @@
package main

import (
metal "github.com/pulumi/pulumi-equinix-metal/sdk/v2/go/equinix"
metal "github.com/pulumi/pulumi-equinix-metal/sdk/v3/go/equinix"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line needs updated as well (to correspond with the updated version).

github-go/main.go Outdated Show resolved Hide resolved
Copy link
Contributor

@scottslowe scottslowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cnunciato cnunciato force-pushed the cnunciato/pass-gh-token branch 2 times, most recently from b2be58b to b946565 Compare January 12, 2023 21:36
@cnunciato cnunciato merged commit fab2f3a into master Jan 13, 2023
@cnunciato cnunciato deleted the cnunciato/pass-gh-token branch January 13, 2023 02:10
dirien pushed a commit to dirien/templates that referenced this pull request Mar 29, 2023
dirien pushed a commit to dirien/templates that referenced this pull request Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants