-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use GITHUB_TOKEN in curl requests, run generate-go-mod.sh #495
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. At some point (not as part of this PR), we need to think about updating the Go version for all these templates.
5d8290d
to
960387d
Compare
@@ -1,7 +1,7 @@ | |||
package main | |||
|
|||
import ( | |||
metal "github.com/pulumi/pulumi-equinix-metal/sdk/v2/go/equinix" | |||
metal "github.com/pulumi/pulumi-equinix-metal/sdk/v3/go/equinix" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line needs updated as well (to correspond with the updated version).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
b2be58b
to
b946565
Compare
b946565
to
3936e0f
Compare
Running this script without a
GITHUB_TOKEN
occasionally yieldsnull
values ingo.mod
files because of GitHub rate limiting. This change adds the ambientGITHUB_TOKEN
tocurl
request headers and re-runs the script to regenerate updated values.Also "downgrades"
github-go
tov4
while we sort out what's going on with #481.