Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github-go dependency problem #481

Closed
figadore opened this issue Dec 13, 2022 · 2 comments
Closed

github-go dependency problem #481

figadore opened this issue Dec 13, 2022 · 2 comments
Assignees
Labels
emergent An issue that was added to the current milestone after planning kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed size/S Estimated effort to complete (1-2 days).
Milestone

Comments

@figadore
Copy link

figadore commented Dec 13, 2022

What happened?

Creates an invalid set of dependencies

go.mod

go 1.17

require (
        github.com/pulumi/pulumi-github/sdk/v4 v5.0.0
        github.com/pulumi/pulumi/sdk/v3 v3.44.2
)

main.go

package main

import (
        "github.com/pulumi/pulumi-github/sdk/v4/go/github"
        "github.com/pulumi/pulumi/sdk/v3/go/pulumi"
)

Steps to reproduce

pulumi new github-go

Expected Behavior

initialize a pulumi stack

Actual Behavior

...
Saved config                                                                                                                                                                                                                                
                                                                                                                                                                                                                                            
Installing dependencies...                                                                                                                                                                                                                  
                                                                                                                                                                                                                                            
go: errors parsing go.mod:                                                                                                                                                                                                                  
/some/path/go.mod:6:2: require github.com/pulumi/pulumi-github/sdk/v4: version "v5.0.0" invalid: should be v4, not v5                                                                                        
error: installing dependencies failed; rerun manually to try again, then run `pulumi up` to perform an initial deployment: `go mod tidy` failed to install dependencies: exit status 1      

Output of pulumi about

CLI          
Version      3.49.0
Go Version   go1.19.3
Go Compiler  gc

Plugins
NAME  VERSION
go    unknown

Host     
OS       debian
Version  bookworm/sid
Arch     x86_64

This project is written in go: executable='/usr/local/go/bin/go' version='go version go1.19.2 linux/amd64'

Backend        
Name           pop-os
URL            file://~
User           reese
Organizations  

Pulumi locates its logs in /tmp by default
warning: Failed to get information about the Pulumi program's dependencies: failed to get modules: exit status 1
warning: Failed to get information about the current stack: No current snapshot

Additional context

Not sure if this issue belongs here or github.com/pulumi/pulumi-github

I also saw in the docs that go 1.18 was required, should that be reflected in this template in go.mod?

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@figadore figadore added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Dec 13, 2022
@cnunciato cnunciato removed the needs-triage Needs attention from the triage team label Dec 15, 2022
@squaremo
Copy link

I can confirm this, same thing happens for me. There's something pretty wacky going on with the versioning here (and in pulumi-github#276).

@cnunciato cnunciato added the size/S Estimated effort to complete (1-2 days). label Jan 12, 2023
@cnunciato cnunciato self-assigned this Jan 12, 2023
@cnunciato cnunciato added this to the 0.83 milestone Jan 12, 2023
@cnunciato cnunciato added the emergent An issue that was added to the current milestone after planning label Jan 12, 2023
lukehoban added a commit to pulumi/pulumi-github that referenced this issue Jan 12, 2023
@lukehoban lukehoban added the resolution/fixed This issue was fixed label Jan 13, 2023
@lukehoban
Copy link
Member

This is fixed by pulumi/pulumi-github#284.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emergent An issue that was added to the current milestone after planning kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed size/S Estimated effort to complete (1-2 days).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants