Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse ensure and dsc_ensure attributes #74

Closed
2 tasks done
michaeltlombardi opened this issue Nov 5, 2020 · 0 comments · Fixed by #88 or #188
Closed
2 tasks done

Collapse ensure and dsc_ensure attributes #74

michaeltlombardi opened this issue Nov 5, 2020 · 0 comments · Fixed by #88 or #188
Assignees
Labels
enhancement New feature or request

Comments

@michaeltlombardi
Copy link

michaeltlombardi commented Nov 5, 2020

Use Case

When writing a manifest for a DSC Resource that is not ensurable, it would be preferable to not have any erroneous ensure keywords to confuse an author; similarly, if a resource is ensurable, it should have one attribute to set, not two; again, to limit confusion and keep a more idiomatic authoring experience.

Describe the Solution You Would Like

Unensurable resources do not have the ensure attribute at all; ensurable resources have the dsc_ensure keyword. This will require moving away from inheriting from the simple provider and instead being it's own provider entirely but will also retain in-place upgrades, not requiring the end-user to modify their manifests, only their puppetfile.

Acceptance Criteria

  • Generated unensurable resource has neither the ensure nor dsc_ensure attributes, can be applied without errors
  • Generated ensurable resource has the dsc_ensure attribute, can be created, updated, and destroyed without errors
@michaeltlombardi michaeltlombardi added the enhancement New feature or request label Nov 5, 2020
@michaeltlombardi michaeltlombardi self-assigned this Nov 24, 2020
pmcmaw added a commit that referenced this issue Nov 25, 2020
…ters

(GH-74, GH-81) Handle parameters in type generation and collapse ensure keywords
david22swan added a commit that referenced this issue Jul 13, 2021
…cept-docs

(GH-74) Add Concept docs for module invocation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment