Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-74) Remove special handling for ensure in the dsc base provider #61

Merged
merged 2 commits into from
Nov 24, 2020
Merged

(GH-74) Remove special handling for ensure in the dsc base provider #61

merged 2 commits into from
Nov 24, 2020

Conversation

michaeltlombardi
Copy link
Contributor

This PR removes the special handling for the ensure keyword
from the dsc base provider to facillitate the collapse of the
ensure and dsc_ensure keywords.

@michaeltlombardi michaeltlombardi requested a review from a team as a code owner November 24, 2020 02:41
@michaeltlombardi
Copy link
Contributor Author

This should be rebased and then merged after #60 as it is based on it.

This commit removes the special handling for the ensure keyword
from the dsc base provider to facillitate the collapse of the
ensure and dsc_ensure keywords.

- Relates to puppetlabs/Puppet.Dsc#74
@pmcmaw pmcmaw added the enhancement New feature or request label Nov 24, 2020
@michaeltlombardi michaeltlombardi marked this pull request as ready for review November 24, 2020 16:29
Copy link
Contributor

@pmcmaw pmcmaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@pmcmaw pmcmaw merged commit 909652f into puppetlabs:main Nov 24, 2020
@michaeltlombardi michaeltlombardi deleted the gh-74/main/remove-ensure branch February 2, 2021 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants