Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Use named volumes in compose where possible #129

Merged
merged 1 commit into from
Sep 13, 2019

Conversation

Iristyle
Copy link
Contributor

@Iristyle Iristyle commented Aug 27, 2019

@Iristyle Iristyle requested a review from a team as a code owner August 27, 2019 20:18
@nwolfe
Copy link
Contributor

nwolfe commented Aug 27, 2019

I'm curious how users will respond to this change, since it's breaking, and requires them to put things into a new directory that takes some extra work to figure out.

I have some hesitation around whether it's okay to be hand-modifying these directories directly from the host machine, but nothing concrete to go on really.

It seems the docker docs around volumes have changed, so maybe this is actually okay!

I do like this better than what we had before.

 - docker-compose supports named volumes, which are different than the
   bind mounts that have been used thus far

   bind mounts expect that the host directory exists on disk and their
   behavior is a bit different, and is discussed in the docs at:

   https://docs.docker.com/storage/bind-mounts/

 - While LCOW is happy to support both volumes and bind mounts, support
   from the platform is a bit different. Specifically it appears that
   bind mounts properly support symlinks (necessary during Postgres
   startup), while volumes do not. An issue has been filed to track that
   issue at moby/moby#39922 (originally filed
   at microsoft/opengcs#337)

 - Switch all volumes to named, except for the one Postgres data volume
   which must remain a bind mount
@Iristyle Iristyle changed the title (maint) Use named volumes in compose if possible (maint) Use named volumes in compose where possible Sep 13, 2019
@Iristyle Iristyle merged commit ab5b6d9 into puppetlabs:master Sep 13, 2019
@Iristyle Iristyle deleted the windows-volume-test branch September 13, 2019 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants