Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(maint) Use named volumes in compose where possible #129

Merged
merged 1 commit into from
Sep 13, 2019
Merged

(maint) Use named volumes in compose where possible #129

merged 1 commit into from
Sep 13, 2019

Commits on Sep 13, 2019

  1. (maint) Use named volumes in compose if possible 

     - docker-compose supports named volumes, which are different than the
   bind mounts that have been used thus far

   bind mounts expect that the host directory exists on disk and their
   behavior is a bit different, and is discussed in the docs at:

   https://docs.docker.com/storage/bind-mounts/

 - While LCOW is happy to support both volumes and bind mounts, support
   from the platform is a bit different. Specifically it appears that
   bind mounts properly support symlinks (necessary during Postgres
   startup), while volumes do not. An issue has been filed to track that
   issue at moby/moby#39922 (originally filed
   at microsoft/opengcs#337)

 - Switch all volumes to named, except for the one Postgres data volume
   which must remain a bind mount
    @Iristyle
    Iristyle committed Sep 13, 2019
    Configuration menu
    Copy the full SHA
    2498437 View commit details
    Browse the repository at this point in the history