(PDK-1143) Allow SimpleProvider to handle multiple namevars #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create, Update and Delete now receive a hash containing all the namevar values and the composite title if the type has multiple namevars
Thomas-Franklin
pushed a commit
to Thomas-Franklin/puppetlabs-panos
that referenced
this pull request
Sep 25, 2018
PDK-1143 allows the resource_api to work nicely with composite providers, this PR is a refactor of the `path_monitor` and `static_routes` which work with composite namevars. This PR's `gemfile` changes should be reverted after puppetlabs/puppet-resource_api#125 is merged.
Thomas-Franklin
approved these changes
Sep 25, 2018
DavidS
approved these changes
Sep 25, 2018
da-ar
changed the title
Thomas-Franklin
pushed a commit
to Thomas-Franklin/puppetlabs-panos
that referenced
this pull request
Sep 25, 2018
PDK-1143 allows the resource_api to work nicely with composite providers, this PR is a refactor of the `path_monitor` and `static_routes` which work with composite namevars. This PR's `gemfile` changes should be reverted after puppetlabs/puppet-resource_api#125 is merged.
Thomas-Franklin
pushed a commit
to Thomas-Franklin/puppetlabs-panos
that referenced
this pull request
Sep 25, 2018
PDK-1143 allows the resource_api to work nicely with composite providers, this PR is a refactor of the `path_monitor` and `static_routes` which work with composite namevars. This PR's `gemfile` changes should be reverted after puppetlabs/puppet-resource_api#125 is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create, Update and Delete now receive a hash containing all the namevar values and the composite title if the type has multiple namevars