Drop remnants of rake package:apple support
#9367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcooper
force-pushed
the
drop_cfproperty_task
branch
from
82e62d6
to
73bb6b7
Compare
joshcooper
changed the title
rake package:apple supportrake package:apple support
mhashizume
approved these changes
May 28, 2024
|
Need to rebase on #9368 |
Shipping the nightly puppet gem is currently failing with:
bundle exec rake pl:ship_nightly_gem FOSS_ONLY=true ANSWER_OVERRIDE=false
rake aborted!
Could not locate a Rake task named 'cfpropertylist' to add as a dependency of 'package:apple'
This was broken in commit 5e4b124 as the packaging repo can no longer load
the cfpropertylist rake task from the puppet repo.
The `package:apple` rake task was used to install a version of CFPropertyList
to speed up plist reads/writes. However, that task has been broken since at
least commit d988fe7 when the file_mapping.yaml
file was deleted:
bundle exec rake package:apple
rake aborted!
Could not load Apple file mappings from 'ext/osx/file_mapping.yaml'
Since the `package:apple` rake task hasn't worked since 2021, delete the
cfproperty rake task and the "pre_tasks" entry that registers the cfpropertylist
task with the packaging gem.
joshcooper
force-pushed
the
drop_cfproperty_task
branch
from
73bb6b7
to
c8f1670
Compare
|
Backport failed for Please cherry-pick the changes locally. git fetch origin 7.x
git worktree add -d .worktree/backport-9367-to-7.x origin/7.x
cd .worktree/backport-9367-to-7.x
git checkout -b backport-9367-to-7.x
ancref=$(git merge-base 77c3d6616625887466011a0e82a2f95ff60578b3 c8f1670bf8efd387d40565a50404d560885063eb)
git cherry-pick -x $ancref..c8f1670bf8efd387d40565a50404d560885063eb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shipping the nightly puppet gem is currently failing with:
This was broken in commit 5e4b124 as the packaging repo can no longer load the cfpropertylist rake task from the puppet repo.
The
package:applerake task was used to install a version of CFPropertyList to speed up plist reads/writes. However, that task has been broken since at least commit d988fe7 when the file_mapping.yaml file was deleted:Since the
package:applerake task hasn't worked since 2021, delete the cfproperty rake task and the "pre_tasks" entry that registers the cfpropertylist task with the packaging gem.