Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop remnants of rake package:apple support #9367

Merged
merged 1 commit into from
May 29, 2024

Commits on May 29, 2024

  1. Drop remnants of rake package:apple support

    Shipping the nightly puppet gem is currently failing with:
    
        bundle exec rake pl:ship_nightly_gem FOSS_ONLY=true ANSWER_OVERRIDE=false
        rake aborted!
        Could not locate a Rake task named 'cfpropertylist' to add as a dependency of 'package:apple'
    
    This was broken in commit 5e4b124 as the packaging repo can no longer load
    the cfpropertylist rake task from the puppet repo.
    
    The `package:apple` rake task was used to install a version of CFPropertyList
    to speed up plist reads/writes. However, that task has been broken since at
    least commit d988fe7 when the file_mapping.yaml
    file was deleted:
    
        bundle exec rake package:apple
        rake aborted!
        Could not load Apple file mappings from 'ext/osx/file_mapping.yaml'
    
    Since the `package:apple` rake task hasn't worked since 2021, delete the
    cfproperty rake task and the "pre_tasks" entry that registers the cfpropertylist
    task with the packaging gem.
    joshcooper committed May 29, 2024
    Configuration menu
    Copy the full SHA
    c8f1670 View commit details
    Browse the repository at this point in the history