(PDB-5278) Fix group by dotted fact path with forward slash #3573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had a look over this PR and tested on PDB-5262 and that case is also resolved. |
sebastian-miclea
approved these changes
Oct 1, 2021
austb
force-pushed
the
pdb-5278/6.x/group-by-dotted-with-slash
branch
from
976f6bb
to
c5ab459
Compare
When grouping by a keyword, honeysql will convert the keyword to SQL by calling `name` on it. But that will not return the entire fact name when there's a forward slash in it because Clojure interprets everything before the forward slash as the "namespace" and everything after as the "name". ``` => (name :facts.foo) "facts.foo" => (name :facts.f/oo) "oo" => (namespace :facts.f/oo) "facts.f" ``` This commit changes the query engine to use sql raw instead of the keyword to avoid splitting on forward slashes.
austb
force-pushed
the
pdb-5278/6.x/group-by-dotted-with-slash
branch
from
c5ab459
to
8103004
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When grouping by a keyword, honeysql will convert the keyword to SQL by
calling
nameon it. But that will not return the entire fact name whenthere's a forward slash in it because Clojure interprets everything
before the forward slash as the "namespace" and everything after as the
"name".
This commit changes the query engine to use sql raw instead of the
keyword to avoid splitting on forward slashes.