Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PDB-5278) Fix group by dotted fact path with forward slash #3573

Open
wants to merge 1 commit into
base: 6.x
Choose a base branch
from
Open

(PDB-5278) Fix group by dotted fact path with forward slash #3573

wants to merge 1 commit into from

Commits on Dec 2, 2021

  1. (PDB-5278) Fix group by dotted fact path with forward slash 

    When grouping by a keyword, honeysql will convert the keyword to SQL by
calling `name` on it. But that will not return the entire fact name when
there's a forward slash in it because Clojure interprets everything
before the forward slash as the "namespace" and everything after as the
"name".

```
=> (name :facts.foo)
"facts.foo"
=> (name :facts.f/oo)
"oo"
=> (namespace :facts.f/oo)
"facts.f"
```

This commit changes the query engine to use sql raw instead of the
keyword to avoid splitting on forward slashes.
    @austb
    austb committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    8103004 View commit details
    Browse the repository at this point in the history