Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PWABuilder] A group of hotfixes from the App Capabilities release #4508

Merged
merged 23 commits into from
Nov 15, 2023

Conversation

Jaylyn-Barbee
Copy link
Contributor

@Jaylyn-Barbee Jaylyn-Barbee commented Nov 3, 2023

fixes #4504, #4474

PR Type

Bugfix
Feature

Describe the current behavior?

  1. No current support for Offline Support
  2. No current separation of Security Tests
  3. html`` being returned in ternary operators instead of null
  4. The red icon inside the filter button in the action items list changes sizes when clicked to become active.
  5. Cannot tab inside the tooltips (Community, SW and Manifest tooltips)
  6. Upon pressing the retest button, the app capabilities score weren't resetting.

Describe the new behavior?

  1. Offline support inside the SW card
  2. New Security warning when delivering mixed content. Can package with warning.
  3. return null where it makes sense instead of html``
  4. Icon stays the same size.
  5. Can now use arrow keys to get inside tooltips to the links (learn more, edit in manifest, or the community links)
  6. App Capabilities score now resets properly

PR Checklist

  • Test: run npm run test and ensure that all tests pass
  • Target main branch (or an appropriate release branch if appropriate for a bug fix)
  • Ensure that your contribution follows standard accessibility guidelines. Use tools like https://webhint.io/ to validate your changes.

Additional Information

…ess the actions inside the tooltip, now i am just trying to set a delay on the hover
… updated sw card to have the proper menu set up. still a bug where i can't press enter to follow links inside sl-menu-item
…tests. still need to update how we display the error/warning for security and also fix the timing of the hover for manifest/sw-info-card(s)
Copy link

github-actions bot commented Nov 3, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-glacier-097fe8710-4508.centralus.2.azurestaticapps.net

Copy link

github-actions bot commented Nov 6, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-glacier-097fe8710-4508.centralus.2.azurestaticapps.net

Copy link

github-actions bot commented Nov 7, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-glacier-097fe8710-4508.centralus.2.azurestaticapps.net

Copy link

github-actions bot commented Nov 7, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-glacier-097fe8710-4508.centralus.2.azurestaticapps.net

Copy link

github-actions bot commented Nov 7, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-glacier-097fe8710-4508.centralus.2.azurestaticapps.net

Copy link

github-actions bot commented Nov 7, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-glacier-097fe8710-4508.centralus.2.azurestaticapps.net

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-glacier-097fe8710-4508.centralus.2.azurestaticapps.net

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-glacier-097fe8710-4508.centralus.2.azurestaticapps.net

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-glacier-097fe8710-4508.centralus.2.azurestaticapps.net

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-glacier-097fe8710-4508.centralus.2.azurestaticapps.net

@beth-panx
Copy link
Contributor

@jgw96 what's up with the playwrite tests? :p

@Jaylyn-Barbee Jaylyn-Barbee added this pull request to the merge queue Nov 15, 2023
Merged via the queue into staging with commit bdd1936 Nov 15, 2023
6 of 7 checks passed
@Jaylyn-Barbee Jaylyn-Barbee deleted the jay/click-tooltips branch November 15, 2023 17:54
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-glacier-097fe8710-4508.centralus.2.azurestaticapps.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants