Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PWABuilder] A group of hotfixes from the App Capabilities release #4508

Merged
merged 23 commits into from
Nov 15, 2023
Merged

[PWABuilder] A group of hotfixes from the App Capabilities release #4508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
fa7ffc6
needed to put menu inside of actionables in tooltips to access them w…
Jaylyn-Barbee Oct 30, 2023
73bd750
in manifest info card i fixed what we needed to make sure you can acc…
Jaylyn-Barbee Oct 31, 2023
a74958c
started the work to update the community dropdown
Jaylyn-Barbee Nov 1, 2023
3c778bd
community dropdown fixed, need to update sw info cards and timer on m…
Jaylyn-Barbee Nov 1, 2023
1e3ca3f
Slotted in new api, updated funky icon size change for red indicator,…
Jaylyn-Barbee Nov 1, 2023
d4f77bc
added offline support detection as well as new https and mix content …
Jaylyn-Barbee Nov 2, 2023
aee0f74
added doc link for offline support, updated security card to handle m…
Jaylyn-Barbee Nov 2, 2023
53e90f9
double checked that the package button was disabled properly
Jaylyn-Barbee Nov 2, 2023
a3d88b2
replaced html` with null across front end
Jaylyn-Barbee Nov 2, 2023
d092521
replacing some mistakes i made with replace all
Jaylyn-Barbee Nov 3, 2023
70c104e
Fixed more improper returns from my replace all
Jaylyn-Barbee Nov 3, 2023
fed0b12
Another incorrect return type fixed
Jaylyn-Barbee Nov 3, 2023
7e1d7ed
properly reset app caps section
Jaylyn-Barbee Nov 6, 2023
d204ed8
hovering the bubbles has a slight delay now, more comfortable
Jaylyn-Barbee Nov 7, 2023
cd46981
anchor clicking solution
Jaylyn-Barbee Nov 7, 2023
d37813f
centered the icon in the error/warning banners better
Jaylyn-Barbee Nov 7, 2023
097c6c8
Merge branch 'staging' into jay/click-tooltips
Jaylyn-Barbee Nov 7, 2023
f8f9dd4
fix to double counting issue
Jaylyn-Barbee Nov 10, 2023
c3c054c
Merge branch 'jay/click-tooltips' of github.com:pwa-builder/PWABuilde…
Jaylyn-Barbee Nov 10, 2023
f75b4d5
updating URL back to main api link, Gleb is merging the update off of…
Jaylyn-Barbee Nov 14, 2023
4ca6ff0
better focus rings on indicators
Jaylyn-Barbee Nov 14, 2023
39de40b
Merge branch 'staging' into jay/click-tooltips
beth-panx Nov 14, 2023
2beb5a9
Merge branch 'staging' into jay/click-tooltips
Jaylyn-Barbee Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions apps/pwabuilder/public/assets/new/offline_support_icon.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
5 changes: 2 additions & 3 deletions apps/pwabuilder/public/assets/new/stop_white.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
10 changes: 5 additions & 5 deletions apps/pwabuilder/src/script/components/android-form.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,7 +601,7 @@ export class AndroidForm extends AppPackageFormBase {
inputHandler: (_, checked) => this.packageOptions.enableNotifications = checked
})}
</div>
</div>` : html``}
</div>` : null}

${this.isGooglePlayApk ?
html`
Expand All @@ -620,7 +620,7 @@ export class AndroidForm extends AppPackageFormBase {
inputHandler: (_, checked) => this.packageOptions.features.locationDelegation!.enabled = checked
})}
</div>
</div>` : html``}
</div>` : null}

${this.isGooglePlayApk ?
html`
Expand All @@ -640,7 +640,7 @@ export class AndroidForm extends AppPackageFormBase {
inputHandler: (_, checked) => this.packageOptions.features.playBilling!.enabled = checked
})}
</div>
</div>` : html``}
</div>` : null}

<div class="form-group">
<label>
Expand Down Expand Up @@ -675,7 +675,7 @@ export class AndroidForm extends AppPackageFormBase {
inputHandler: (_, checked) => this.packageOptions.isChromeOSOnly = checked
})}
</div>
</div>` : html``}
</div>` : null}
Jaylyn-Barbee marked this conversation as resolved.
Show resolved Hide resolved

<div class="form-group">
<label>
Expand Down Expand Up @@ -750,7 +750,7 @@ export class AndroidForm extends AppPackageFormBase {
</div>

${this.renderSigningKeyFields()}` :
html``}
null}

</div>
</sl-details>
Expand Down
Loading
Loading