-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROB: Fix errors/warnings on no /Resources within extract_text #1276
Conversation
fix py-pdf#1272 (in text) and py-pdf#1269 (in Xform)
Codecov Report
@@ Coverage Diff @@
## main #1276 +/- ##
=======================================
Coverage 95.02% 95.03%
=======================================
Files 30 30
Lines 4968 4974 +6
Branches 1023 1024 +1
=======================================
+ Hits 4721 4727 +6
Misses 140 140
Partials 107 107
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Co-authored-by: Matthew Peveler <[email protected]>
Co-authored-by: Matthew Peveler <[email protected]>
Thank you for the PR @pubpub-zz 🤗 |
According to TABLE 3.27 Entries in a page object in the PDF 1.7 specs, the
As it is required, I would throw an exception in strict mode and a Do you know if we handle the inheritance case? From what can it be inherited? |
I've added some code to check in the parents. But if not present. I do not think it worth to check that Tj or TJ is present in the content (it will complexify the code with very limited interest) |
Robustness (ROB): - Fix errors/warnings on no /Resources within extract_text (#1276) - Add required line separators in ContentStream ArrayObjects (#1281) Maintenance (MAINT): - Use NameObject idempotency (#1290) Testing (TST): - Rectangle deletion (#1289) - Add workflow tests (#1287) - Remove files after tests ran (#1286) Packaging (PKG): - Add minimum version for typing_extensions requirement (#1277) Full Changelog: 2.10.3...2.10.4
fix #1272 (in text) and #1269 (in Xform)