Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROB: Add required line separators in ContentStream ArrayObjects #1281

Merged
merged 1 commit into from
Aug 27, 2022

Conversation

pubpub-zz
Copy link
Collaborator

fix #1278

@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #1281 (72f8f2d) into main (2ddc48a) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #1281      +/-   ##
==========================================
- Coverage   94.92%   94.90%   -0.02%     
==========================================
  Files          30       30              
  Lines        4966     4968       +2     
  Branches     1022     1023       +1     
==========================================
+ Hits         4714     4715       +1     
  Misses        141      141              
- Partials      111      112       +1     
Impacted Files Coverage Δ
PyPDF2/generic/_data_structures.py 96.63% <50.00%> (-0.16%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@MartinThoma MartinThoma changed the title ROB : add required line separators in content stream arrays ROB: Add required line separators in ContentStream ArrayObjects Aug 27, 2022
@MartinThoma MartinThoma merged commit c819acb into py-pdf:main Aug 27, 2022
@MartinThoma
Copy link
Member

Thank you for the fix @pubpub-zz 🤗 I feel like PyPDF2 is getting more and more robust 🎉

MartinThoma added a commit that referenced this pull request Aug 28, 2022
Robustness (ROB):
-  Fix errors/warnings on no /Resources within extract_text (#1276)
-  Add required line separators in ContentStream ArrayObjects (#1281)

Maintenance (MAINT):
-  Use NameObject idempotency (#1290)

Testing (TST):
-  Rectangle deletion (#1289)
-  Add workflow tests (#1287)
-  Remove files after tests ran (#1286)

Packaging (PKG):
-  Add minimum version for typing_extensions requirement (#1277)

Full Changelog: 2.10.3...2.10.4
@pubpub-zz pubpub-zz deleted the iss_1278 branch September 3, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IndexError: list index out of range
2 participants