Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: deprecate PdfMerger,AnnotationBuilder and other depreciations cleanup #2813

Merged
merged 21 commits into from
Sep 14, 2024

Conversation

pubpub-zz
Copy link
Collaborator

in preparation of release 5.0.0 coming

in preparation of release 5.0.0 coming
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.95%. Comparing base (a790532) to head (b52106c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2813      +/-   ##
==========================================
- Coverage   95.99%   95.95%   -0.04%     
==========================================
  Files          51       51              
  Lines        8780     8490     -290     
  Branches     1753     1696      -57     
==========================================
- Hits         8428     8147     -281     
+ Misses        209      202       -7     
+ Partials      143      141       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pubpub-zz pubpub-zz marked this pull request as draft August 26, 2024 13:17
@pubpub-zz
Copy link
Collaborator Author

need first to improve coverage (indirectly degraded)

@pubpub-zz pubpub-zz changed the title MAINT: deprecate PdfMerger MAINT: deprecate PdfMerger and other depreciation cleanup Aug 27, 2024
@pubpub-zz pubpub-zz changed the title MAINT: deprecate PdfMerger and other depreciation cleanup MAINT: deprecate PdfMerger and other depreciations cleanup Aug 27, 2024
@pubpub-zz pubpub-zz changed the title MAINT: deprecate PdfMerger and other depreciations cleanup MAINT: deprecate PdfMerger,AnnotationBuilder and other depreciations cleanup Aug 27, 2024
@pubpub-zz
Copy link
Collaborator Author

to be able to pass coverage, I add to reactivate some code that is currently unreachable (outlines currently can only word with dest array) issue #2814 is here to track this

@pubpub-zz pubpub-zz marked this pull request as ready for review August 27, 2024 12:38
@pubpub-zz
Copy link
Collaborator Author

This PR is ready for review: the coverage reduced by 0.05% comes from the code size decreased

@pubpub-zz
Copy link
Collaborator Author

@stefan6419846
this PR is ready for review

pypdf/_writer.py Outdated Show resolved Hide resolved
pypdf/constants.py Outdated Show resolved Hide resolved
@pubpub-zz
Copy link
Collaborator Author

@stefan6419846
good to complete

pypdf/constants.py Outdated Show resolved Hide resolved
@pubpub-zz
Copy link
Collaborator Author

@stefan6419846
Good now

@stefan6419846 stefan6419846 merged commit 1bbc301 into py-pdf:main Sep 14, 2024
15 of 16 checks passed
@pubpub-zz pubpub-zz mentioned this pull request Sep 15, 2024
pubpub-zz added a commit that referenced this pull request Sep 17, 2024
## Version 5.0.0, 2024-09-15

This version drops support for Python 3.7 (not maintained since July 2023), PdfMerger (use PdfWriter instead) and AnnotationBuilder (use annotations instead).


### Deprecations (DEP)
- Remove the deprecated PfdMerger and AnnotationBuilder classes and other deprecations cleanup (#2813)
- Drop Python 3.7 support (#2793)

### New Features (ENH)
- Add capability to remove /Info from PDF (#2820)
- Add incremental capability to PdfWriter (#2811)
- Add UniGB-UTF16 encodings (#2819)
- Accept utf strings for metadata (#2802)
- Report PdfReadError instead of RecursionError (#2800)
- Compress PDF files merging identical objects (#2795)

### Bug Fixes (BUG)
- Fix sheared image (#2801)

### Robustness (ROB)
- Robustify .set_data() (#2821)
- Raise PdfReadError when missing /Root in trailer (#2808)
- Fix extract_text() issues on damaged PDFs (#2760)
- Handle images with empty data when processing an image from bytes (#2786)

### Developer Experience (DEV)
- Fix coverage uploads (#2832)
- Test against Python 3.13 (#2776)


[Full Changelog](4.3.1...5.0.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants