MAINT: Update version of deprecation_with_replacement

[j-t-1]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.99%. Comparing base (a337664) to head (b537f73).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2861   +/-   ##
=======================================
  Coverage   95.99%   95.99%           
=======================================
  Files          51       51           
  Lines        8516     8516           
  Branches     1698     1698           
=======================================
  Hits         8175     8175           
  Misses        200      200           
  Partials      141      141           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[stefan6419846]

Seems like we missed them during the cleanup, as they should already have been removed as well - they already were errors if I am not mistaken. Thus I do not really consider this change to be correct. Depending on whether we yank the 5.0.0 release, this might go into the fixed 5.0.0 release with a complete cleanup.

[j-t-1]

If it was not an __init__.py file would this change be okay?

Is "AnnotationBuilder" okay to be in __all__?

[stefan6419846]

No, I am questioning why we are still delaying the deprecation which - if I understand correctly, should already have happened by completely removing the offending code.

[j-t-1]

These were deprecate_with_replacement in 4.0.0 and made deprecation_with_replacement in #2813, but the 4.0.0 should have been increased to 5.0.0. However, on further consideration, because it is an __init__.py file I think it needs to be removed from this file. We are agreeing for its removal but for different reasons.