Make slice::compute return signed integers #808
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed results are necessary for at least the step, which may be negative. If unsigned results are needed for the others, this should be done with a static_cast; the result of a reintepret_cast between signed and unsigned is compiler-defined. I think it's better to just pass the ssize_t values directly to the user and let them handle a conversion to unsigned if needed.
|
This seems a good fit with #782. |
|
I agree that this would work well alongside #782. @TallJimbo Looks like there are addition conversion issues that would need to be cleaned up here. |
19 tasks
|
Superseded by #1394 |
|
How to express this "a[0:3, 0:3]" in python as c ++? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed results are necessary for at least the step, which may be negative.
If unsigned results are needed for the others, this should be done with a
static_cast; the result of areintepret_castbetween signed and unsigned is compiler-defined. I think it's better to just pass the ssize_t values directly to the user and let them handle a conversion to unsigned if needed.