Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make slice::compute return signed integers #808

Closed
wants to merge 1 commit into from
Closed

Make slice::compute return signed integers #808

wants to merge 1 commit into from

Commits on Apr 19, 2017

  1. Make slice::compute return signed integers 

    Signed results are necessary for at least the step, which may
be negative.

If unsigned results are needed for the others, this should be
done with a static_cast; the result of a reintepret_cast
between signed and unsigned is compiler-defined.  I think it's
better to just pass the ssize_t values directly to the user
and let them handle a conversion to unsigned if needed.
    @TallJimbo
    TallJimbo committed Apr 19, 2017
    Configuration menu
    Copy the full SHA
    41b0418 View commit details
    Browse the repository at this point in the history