More consistency checks

[shoyer]

The first commit here is just https://github.com/pydata/xarray/pull/2858/files

It appears that we have our work cut-out for us -- about 180 failing tests if we turn on these more rigorous checks by default:

collected 8308 items

xarray/tests/test_accessors.py ............................................................................... [  0%]
..................................................................                                             [  1%]
xarray/tests/test_backends.py ...............................x..F.................F........................... [  2%]
......................x..F.................F......................F.FFFF.FFFFF.FFFFFFF......F.FxFFFF..F....... [  4%]
s...F.F.F.xxxxFFF.FFFF.FFFFF.FFFFFFF......F.FxFFFF..F.......s...F.F.F.xxxxFF..............................x..F [  5%]
.............................................x..F...............ss..............................x..F.......... [  6%]
.......................................x..F..........F...................................x..F................. [  8%]
...........................x..F..F..............................................x..F.................F........ [  9%]
.......FF..................................x..F.................F...............FF......F..................... [ 10%]
........x..F.................F...............FF......................................................sssssssss [ 11%]
sssssss.....................................x......F........ssssssssssssssssssssssssssssssssssssssssssssssssss [ 13%]
ssssssssssssssssssssssssssssss..........................................................................       [ 14%]
xarray/tests/test_backends_api.py .                                                                            [ 14%]
xarray/tests/test_backends_file_manager.py ...........................                                         [ 14%]
xarray/tests/test_backends_locks.py .                                                                          [ 14%]
xarray/tests/test_backends_lru_cache.py ........                                                               [ 14%]
xarray/tests/test_cftime_offsets.py .......................................................................... [ 15%]
.............................................................................................................. [ 17%]
.............................................................................................................. [ 18%]
.............................................................................................................. [ 19%]
.............................................................................................................. [ 21%]
.............................................................................................................. [ 22%]
.............................................................................................................. [ 23%]
.............................................................................................................. [ 25%]
.............................................................................................................. [ 26%]
.............................................................................................................. [ 27%]
.............................................................................................................. [ 29%]
.............................................................................................................. [ 30%]
.............................................................................................................. [ 31%]
.............................................................................................................. [ 33%]
.............................................................................................................. [ 34%]
.............................................................................................................. [ 35%]
.............................................................................................................. [ 37%]
.............................................................................................................. [ 38%]
.............................................................................................................. [ 39%]
........                                                                                                       [ 39%]
xarray/tests/test_cftimeindex.py ............................................................................. [ 40%]
.............................................................................................................. [ 42%]
.............................................................................................................. [ 43%]
.............................................................................................................. [ 44%]
.............................................................................................................. [ 46%]
.......................................................................................x                       [ 47%]
xarray/tests/test_cftimeindex_resample.py .................................................................... [ 47%]
.............................................................................................................. [ 49%]
.............................................................................................................. [ 50%]
.............................................................................................................. [ 51%]
.............................................................................................................. [ 53%]
...................................................................................                            [ 54%]
xarray/tests/test_coding.py .........                                                                          [ 54%]
xarray/tests/test_coding_strings.py ...................                                                        [ 54%]
xarray/tests/test_coding_times.py ............................................................................ [ 55%]
.............................................................................................................. [ 56%]
.............................................................................................................. [ 58%]
..............................                                                                                 [ 58%]
xarray/tests/test_combine.py F.................................................x                               [ 59%]
xarray/tests/test_computation.py .................................                                             [ 59%]
xarray/tests/test_conventions.py ..............................................x..F............s...            [ 60%]
xarray/tests/test_dask.py ................................................x...................                 [ 61%]
xarray/tests/test_dataarray.py ............F.......................................................FF......... [ 62%]
................................s.s...F...................FFFF........................sss..................... [ 63%]
.............................................................................................................. [ 64%]
.............................................................................................................. [ 66%]
.............................................................................................................. [ 67%]
..........................................................................................................ssss [ 68%]
sssssssss                                                                                                      [ 68%]
xarray/tests/test_dataset.py ..........................F..............F...FF....................F.F........... [ 69%]
...s.FFFFF...................FF..............F..............................FFF.F.FFF.FFFF..FFFFFFF...FFFF..FF [ 71%]
FFFF....F.....FFFFFF.......................................................................................... [ 72%]
.............................................................................................................. [ 73%]
......................................................................................ssssssssssssssss........ [ 75%]
.............................................................................................................. [ 76%]
.............................................................................................................. [ 77%]
...........................................................................................                    [ 78%]
xarray/tests/test_distributed.py FFFFFFFFFFsFsFss.FF                                                           [ 79%]
xarray/tests/test_dtypes.py .......................................                                            [ 79%]
xarray/tests/test_duck_array_ops.py .....................................ss..............ss..............ss... [ 80%]
...ss......ss..............ss......................................................ss......ss................. [ 81%]
.............ss..............ss..............ss......ss......ss..............ss............................... [ 83%]
.......................ss......ss................ssssssssss..........ssssssssss..........ssssssssss..........s [ 84%]
sssssssss..........ssssss..............ssssss..............ssssss..............ssssss..............sssssssssss [ 85%]
.s.s.s.s.sssssssssss.s.s.s.s.sssssssssss.s.s.s.s.sssssssssss.s.s.s.s.sssssss.s.s.s.s.s.s.sssssss.s.s.s.s.s.s.s [ 87%]
ssssss.s.s.s.s.s.s.sssssss.s.s.s.s.s.s........................................................................ [ 88%]
..................................                                                                             [ 88%]
xarray/tests/test_extensions.py ....                                                                           [ 88%]
xarray/tests/test_formatting.py ...............                                                                [ 88%]
xarray/tests/test_groupby.py ........                                                                          [ 89%]
xarray/tests/test_indexing.py ................................................................................ [ 90%]
......................................                                                                         [ 90%]
xarray/tests/test_interp.py FFFFFFFssFF..FF.........FF...FFFFFx.F.F....                                        [ 90%]
xarray/tests/test_merge.py .................                                                                   [ 91%]
xarray/tests/test_merge.py .................                                                                   [ 91%]
xarray/tests/test_missing.py .................................                                                 [ 91%]
xarray/tests/test_nputils.py ...                                                                               [ 91%]
xarray/tests/test_options.py ...........x                                                                      [ 91%]
xarray/tests/test_plot.py .................................................................................... [ 12%]
.............................................................................................................s [ 28%]
.....................................................................................sss...................... [ 44%]
.........................                                                                                      [ 48%]
xarray/tests/test_testing.py .                                                                                 [ 48%]
xarray/tests/test_tutorial.py ss                                                                               [ 48%]
xarray/tests/test_ufuncs.py FFF.....................................................................           [ 59%]
xarray/tests/test_utils.py ............................                                                        [ 63%]
xarray/tests/test_variable.py ................................................................................ [ 74%]
................................................................................xxxX.......................... [ 91%]
.......................................xxxxxxx...............                                                  [100%]

============= 180 failed, 7733 passed, 356 skipped, 38 xfailed, 1 xpassed, 10 warnings in 465.51 seconds =============

[pep8speaks]

Hello @shoyer! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-06-18 09:35:59 UTC

[spencerkclark]

Wow, thanks for looking into this rigorously @shoyer. Hopefully some of these have similar root causes.

[shoyer]

Fixing these turned out to be much easier than I thought.

This needs a release note but otherwise I think is good to go.

[shoyer]

I'm pretty sure this fixed a bug somewhere (or else I wouldn't have said this needs release notes), but I can no longer remember what that was!

I'm going to go ahead and merge this shortly, assuming that tests pass after merging in master.