Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize isel for lazy array equality checking #3588

Merged
merged 19 commits into from
Feb 24, 2020
Merged

Optimize isel for lazy array equality checking #3588

merged 19 commits into from
Feb 24, 2020

Conversation

dcherian
Copy link
Contributor

@dcherian dcherian commented Dec 3, 2019

This mostly adds tests that already pass (yay!).

@dcherian dcherian changed the title Optimize lazy equiv Optimize isel for lazy array equality checking Dec 3, 2019
dcherian
dcherian commented Dec 3, 2019
View reviewed changes
xarray/core/variable.py Outdated Show resolved Hide resolved
@dcherian dcherian mentioned this pull request Dec 14, 2019
Open
@dcherian
Merge branch 'master' of github.com:pydata/xarray into optimize-lazy-…
9291b91 
…equiv

* 'master' of github.com:pydata/xarray: (28 commits)
  Add nanmedian for dask arrays (pydata#3604)
  added pyinterp to related projects (pydata#3655)
  Allow incomplete hypercubes in combine_by_coords (pydata#3649)
  concat keeps attrs from first variable. (pydata#3637)
  Extend DatetimeAccessor properties and support `.dt` accessor for Timedelta (pydata#3612)
  update readthedocs.yml (pydata#3639)
  silence sphinx warnings round 3 (pydata#3602)
  Fix/quantile wrong errmsg (pydata#3635)
  Provide shape info in shape mismatch error. (pydata#3619)
  Minor doc fixes (pydata#3615)
  Respect user-specified coordinates attribute. (pydata#3487)
  Add Facetgrid.row_labels & Facetgrid.col_labels (pydata#3597)
  Fix pint integration tests (pydata#3600)
  Minor fix to combine_by_coords to allow for the combination of CFTimeIndexes separated by large time intervals (pydata#3543)
  Fix map_blocks HLG layering (pydata#3598)
  Silence sphinx warnings: Round 2 (pydata#3592)
  2x~5x speed up for isel() in most cases (pydata#3533)
  remove xarray again (pydata#3591)
  fix plotting with transposed nondim coords. (pydata#3441)
  make coarsen reductions consistent with reductions on other classes (pydata#3500)
  ...
@dcherian dcherian mentioned this pull request Jan 17, 2020
Closed
11 tasks
crusaderky
crusaderky approved these changes Jan 17, 2020
View reviewed changes
xarray/core/variable.py Outdated Show resolved Hide resolved
dcherian and others added 4 commits January 17, 2020 09:22
@dcherian @crusaderky
Update xarray/core/variable.py
96d8ded 
Co-Authored-By: crusaderky <[email protected]>
@dcherian
minor.
2ce560f
@dcherian
Merge remote-tracking branch 'upstream/master' into optimize-lazy-equiv
6b20a3e 
* upstream/master: (23 commits)
  Feature/align in dot (pydata#3699)
  ENH: enable `H5NetCDFStore` to work with already open h5netcdf.File a… (pydata#3618)
  One-off isort run (pydata#3705)
  hardcoded xarray.__all__ (pydata#3703)
  Bump mypy to v0.761 (pydata#3704)
  remove DataArray and Dataset constructor deprecations for 0.15  (pydata#3560)
  Tests for variables with units (pydata#3654)
  Add an example notebook using apply_ufunc to vectorize 1D functions (pydata#3629)
  Use encoding['dtype'] over data.dtype when possible within CFMaskCoder.encode (pydata#3652)
  allow passing any iterable to drop when dropping variables (pydata#3693)
  Typo on DataSet/DataArray.to_dict documentation (pydata#3692)
  Fix mypy type checking tests failure in ds.merge (pydata#3690)
  Explicitly convert result of pd.to_datetime to a timezone-naive type (pydata#3688)
  ds.merge(da) bugfix (pydata#3677)
  fix docstring for combine_first: returns a Dataset (pydata#3683)
  Add option to choose mfdataset attributes source. (pydata#3498)
  How do I add a new variable to dataset. (pydata#3679)
  Add map_blocks example to whats-new (pydata#3682)
  Make dask names change when chunking Variables by different amounts. (pydata#3584)
  raise an error when renaming dimensions to existing names (pydata#3645)
  ...
@dcherian
Merge branch 'optimize-lazy-equiv' of github.com:dcherian/xarray into…
7b1a55f 
… optimize-lazy-equiv

* 'optimize-lazy-equiv' of github.com:dcherian/xarray:
  Update xarray/core/variable.py
@dcherian
Copy link
Contributor Author

Thanks for the review @crusaderky

@dcherian dcherian merged commit f468a06 into pydata:master Feb 24, 2020
@dcherian dcherian deleted the optimize-lazy-equiv branch February 24, 2020 18:26
dcherian added a commit to johnomotani/xarray that referenced this pull request Feb 24, 2020
@dcherian
Merge remote-tracking branch 'upstream/master' into fix-contourf-set_…
103657d 
…under

* upstream/master: (71 commits)
  Optimize isel for lazy array equality checking (pydata#3588)
  pin msgpack (pydata#3793)
  concat now handles non-dim coordinates only present in one dataset (pydata#3769)
  Add new h5netcdf backend phony_dims kwarg (pydata#3753)
  always use dask_array_type for isinstance calls (pydata#3787)
  allow formatting the diff of ndarray attributes (pydata#3728)
  Pint support for variables (pydata#3706)
  Format issue template comment as md comment (pydata#3790)
  Avoid running test_open_mfdataset_list_attr without dask (pydata#3780)
  remove seaborn.apionly compatibility (pydata#3749)
  Python 3.8 CI (pydata#3727)
  PKG: Explicitly add setuptools dependency (pydata#3628)
  update whats-new
  Typo in Universal Functions section (pydata#3663)
  Release v0.15.0
  fix setup.cfg
  Documentation fixes (pydata#3732)
  Remove extra && in PR template (pydata#3730)
  Remove garbage text inserted in DASK_LICENSE (pydata#3729)
  Avoid unsafe use of pip (pydata#3726)
  ...
@max-sixty
Copy link
Collaborator

Great, thanks @dcherian !

@andersy005 andersy005 mentioned this pull request Feb 15, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crusaderky crusaderky crusaderky approved these changes

@shoyer shoyer Awaiting requested review from shoyer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

optimizing xarray operations for lazy array equality test
4 participants
@dcherian @max-sixty @shoyer @crusaderky