Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid running test_open_mfdataset_list_attr without dask #3780

Merged
merged 1 commit into from
Feb 19, 2020
Merged

Avoid running test_open_mfdataset_list_attr without dask #3780

merged 1 commit into from
Feb 19, 2020

Conversation

ArchangeGabriel
Copy link
Contributor

@ArchangeGabriel ArchangeGabriel mentioned this pull request Feb 19, 2020
Closed
@max-sixty max-sixty self-requested a review February 19, 2020 12:04
max-sixty
max-sixty approved these changes Feb 19, 2020
View reviewed changes
Copy link
Collaborator

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ArchangeGabriel

Test failure looks unrelated

@max-sixty
Copy link
Collaborator

You're welcome to give yourself credit in the whatsnew!

@ArchangeGabriel
Copy link
Contributor Author

I don’t care about credit, so the question is whether you want this to be documented as a whatsnew entry (I don’t know your workflow/rules about this). ;)

@max-sixty
Copy link
Collaborator

I don’t care about credit, so the question is whether you want this to be documented as a whatsnew entry (I don’t know your workflow/rules about this). ;)

Ideally yes (and we like giving credit to everyone who contributes!), but we appreciate the contribution and will merge regardless. Thank you.

@ArchangeGabriel
Copy link
Contributor Author

Should it be under bug fixes or internal changes?

@max-sixty
Copy link
Collaborator

Should it be under bug fixes or internal changes?

I think internal changes, given it's not user-facing

@ArchangeGabriel
Copy link
Contributor Author

Added the whatsnew entry and replaced the commit.

max-sixty
max-sixty approved these changes Feb 19, 2020
View reviewed changes
Copy link
Collaborator

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ArchangeGabriel !

@max-sixty max-sixty merged commit 90e734a into pydata:master Feb 19, 2020
dcherian added a commit to johnomotani/xarray that referenced this pull request Feb 24, 2020
@dcherian
Merge remote-tracking branch 'upstream/master' into fix-contourf-set_…
103657d 
…under

* upstream/master: (71 commits)
  Optimize isel for lazy array equality checking (pydata#3588)
  pin msgpack (pydata#3793)
  concat now handles non-dim coordinates only present in one dataset (pydata#3769)
  Add new h5netcdf backend phony_dims kwarg (pydata#3753)
  always use dask_array_type for isinstance calls (pydata#3787)
  allow formatting the diff of ndarray attributes (pydata#3728)
  Pint support for variables (pydata#3706)
  Format issue template comment as md comment (pydata#3790)
  Avoid running test_open_mfdataset_list_attr without dask (pydata#3780)
  remove seaborn.apionly compatibility (pydata#3749)
  Python 3.8 CI (pydata#3727)
  PKG: Explicitly add setuptools dependency (pydata#3628)
  update whats-new
  Typo in Universal Functions section (pydata#3663)
  Release v0.15.0
  fix setup.cfg
  Documentation fixes (pydata#3732)
  Remove extra && in PR template (pydata#3730)
  Remove garbage text inserted in DASK_LICENSE (pydata#3729)
  Avoid unsafe use of pip (pydata#3726)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-sixty max-sixty max-sixty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_open_mfdataset_list_attr is ran even when dask is not available
2 participants
@ArchangeGabriel @max-sixty