Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: run mypy in full env #4929

Merged
merged 12 commits into from
Feb 22, 2021
Merged

CI: run mypy in full env #4929

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
2ff12a1
CI: run mypy in full env
mathause Feb 19, 2021
08ed48a
mypy: show_error_codes
mathause Feb 19, 2021
5bc4cf1
[skip-ci] add skip ci option & version comment
mathause Feb 21, 2021
b9ae449
Apply suggestions from code review
mathause Feb 21, 2021
8a50a40
Update .github/workflows/ci-additional.yaml
mathause Feb 21, 2021
2ba4e98
Update .github/workflows/ci-additional.yaml
mathause Feb 22, 2021
2623a37
Merge branch 'master' into mypy_full_env
mathause Feb 22, 2021
9b53189
Merge branch 'mypy_full_env' of https://github.com/mathause/xarray in…
mathause Feb 22, 2021
358df23
update mypy version
mathause Feb 22, 2021
dbd9aa2
Update .pre-commit-config.yaml
mathause Feb 22, 2021
c82ab55
[skip-ci] install mypy from file
mathause Feb 22, 2021
92854f4
Merge branch 'mypy_full_env' of https://github.com/mathause/xarray in…
mathause Feb 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/ci-additional.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,8 @@ jobs:
typing:
name: Type checking (mypy)
runs-on: "ubuntu-latest"
needs: detect-ci-trigger
if: needs.detect-ci-trigger.outputs.triggered == 'false'
mathause marked this conversation as resolved.
Show resolved Hide resolved
defaults:
run:
shell: bash -l {0}
Expand All @@ -185,7 +187,7 @@ jobs:
run: |
mamba env update -f ci/requirements/environment.yml
- name: Install mypy
run: |
run: | # version must correstpond to the one in .pre-commit-config.yaml
mathause marked this conversation as resolved.
Show resolved Hide resolved
mamba install mypy=0.800
keewis marked this conversation as resolved.
Show resolved Hide resolved
- name: Install xarray
run: |
Expand Down
1 change: 1 addition & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ repos:
# - id: velin
# args: ["--write", "--compact"]
- repo: https://github.com/pre-commit/mirrors-mypy
# version must correstpond to the one in .github/workflows/ci-additional.yaml
mathause marked this conversation as resolved.
Show resolved Hide resolved
mathause marked this conversation as resolved.
Show resolved Hide resolved
rev: v0.800
hooks:
- id: mypy
Expand Down