Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: run mypy in full env #4929

Merged
merged 12 commits into from
Feb 22, 2021
Merged

CI: run mypy in full env #4929

merged 12 commits into from
Feb 22, 2021

Conversation

mathause
Copy link
Collaborator

@mathause mathause commented Feb 19, 2021

I only added one run for py3.8 latest. To be entirely sure we could also check the typing py37-min-all-deps but it feels like overkill...


Ok, looks good - the failure is expected - see #4878.

@keewis
Copy link
Collaborator

keewis commented Feb 19, 2021

the workflow looks good to me, but it should probably be possible to skip it using [skip-ci]

Edit: since it will always fail right now, should we disable this workflow for now and you enable it in #4878?

.pre-commit-config.yaml Outdated Show resolved Hide resolved
.github/workflows/ci-additional.yaml Outdated Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
Copy link
Collaborator

@keewis keewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. Before merging, I think we should disable the CI for now, though, please enable it in #4878

.github/workflows/ci-additional.yaml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
@keewis
Copy link
Collaborator

keewis commented Feb 22, 2021

Thanks, @mathause, looks good to me.

I wonder if we should move this into linting? That way, running the linting on autoupdate PRs would be easier. That should probably be a new PR, though, so I'm merging.

@keewis keewis merged commit 200c2b2 into pydata:master Feb 22, 2021
@mathause mathause deleted the mypy_full_env branch February 22, 2021 16:41
@mathause
Copy link
Collaborator Author

Thanks - just for reference - this is currently unconditionally inactive & should be activated in #4878

@keewis keewis mentioned this pull request Feb 22, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

check mypy at the end of some CI runs?
3 participants