Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autoupdate mypy #4943

Merged
merged 8 commits into from
Feb 23, 2021
Merged

autoupdate mypy #4943

merged 8 commits into from
Feb 23, 2021

Conversation

keewis
Copy link
Collaborator

@keewis keewis commented Feb 22, 2021

As requested in #4929, this will automatically sync the mypy version in the mypy_only environment file with the hook version.

  • Passes pre-commit run --all-files

Edit: triggering the linting workflow from a automatically generated PR might need a bit more investigation. pandas works around that by running pre-commit run -a after pre-commit autoupdate completed, but that doesn't work if we want to also run the new mypy CI.

Copy link
Collaborator

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clever! Great idea!

Copy link
Collaborator

@mathause mathause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot - looks good. I am sure there is an xckd comic on this ;-)

.github/workflows/sync_linter_versions.py Outdated Show resolved Hide resolved
@keewis keewis merged commit fd001f1 into pydata:master Feb 23, 2021
@keewis keewis deleted the autoupdate-mypy branch February 23, 2021 17:28
@mathause
Copy link
Collaborator

Thanks!

dcherian added a commit to dcherian/xarray that referenced this pull request Mar 8, 2021
* upstream/master: (46 commits)
  pin netCDF4=1.5.3 in min-all-deps (pydata#4982)
  fix matplotlib errors for single level discrete colormaps (pydata#4256)
  Adapt exception handling in CFTimeIndex.__sub__ and __rsub__ (pydata#5006)
  Update options.py (pydata#5000)
  Adjust tests to use updated pandas syntax for offsets (pydata#4537)
  add a combine_attrs parameter to Dataset.merge (pydata#4895)
  Support for dask.graph_manipulation (pydata#4965)
  raise on passing axis to Dataset.reduce methods (pydata#4940)
  Whatsnew for 0.17.1 (pydata#4963)
  Refinements to how-to-release (pydata#4964)
  DOC: add example for reindex (pydata#4956)
  DOC: rm np import (pydata#4949)
  Add 0.17.0 release notes (pydata#4953)
  document update as inplace (pydata#4932)
  bump the dependencies (pydata#4942)
  Upstream CI: limit runtime (pydata#4946)
  typing for numpy 1.20 (pydata#4878)
  Use definition of DTypeLike from Numpy if found (pydata#4941)
  autoupdate mypy (pydata#4943)
  Add DataArrayCoarsen.reduce and DatasetCoarsen.reduce methods (pydata#4939)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants