Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port property-related workaround from infer_functiondef to infer_property #2119

Merged

Conversation

jacobtylerwalls
Copy link
Member

Type of Changes

Type
🐛 Bug fix

Description

Refs #1490

Needed for pylint-dev/pylint#8494

@jacobtylerwalls jacobtylerwalls added this to the 2.16.0 milestone Apr 15, 2023
@jacobtylerwalls jacobtylerwalls changed the title Port property-related workaround from infer_functiondef to infer_property Port property-related workaround from infer_functiondef to infer_property Apr 15, 2023
@codecov
Copy link

codecov bot commented Apr 15, 2023

Codecov Report

Merging #2119 (1623a8a) into main (ee2d4bd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2119   +/-   ##
=======================================
  Coverage   92.80%   92.80%           
=======================================
  Files          94       94           
  Lines       10958    10959    +1     
=======================================
+ Hits        10170    10171    +1     
  Misses        788      788           
Flag Coverage Δ
linux 92.52% <100.00%> (+<0.01%) ⬆️
pypy 88.09% <100.00%> (+<0.01%) ⬆️
windows 92.36% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
astroid/brain/brain_builtin_inference.py 91.59% <100.00%> (+0.01%) ⬆️

@jacobtylerwalls jacobtylerwalls merged commit 5869ee3 into pylint-dev:main Apr 16, 2023
@jacobtylerwalls jacobtylerwalls deleted the fix-parent-locals-property branch April 16, 2023 16:14
@Pierre-Sassoulas Pierre-Sassoulas modified the milestones: 2.16.0, 3.0 Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants