-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ruff instead of flake8 pyupgrade autoflake and isort #6
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6 +/- ##
==========================================
- Coverage 87.00% 86.96% -0.04%
==========================================
Files 33 33
Lines 400 399 -1
Branches 81 81
==========================================
- Hits 348 347 -1
Misses 48 48
Partials 4 4
☔ View full report in Codecov by Sentry. |
No reason to make code stale, if pre-commit and tests agree. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeeeah, hihihihi 🙃
check blanket noqa.......................................................Failed
- hook id: python-check-blanket-noqa
- exit code: 1
pylint_pytest/checkers/class_attr_loader.py:52: except Exception: # pylint: disable=broad-except # noqa
pylint_pytest/utils.py:118: except Exception: # pylint: disable=broad-except # noqa
You'd probably have to exclude the specific ruff error: https://docs.astral.sh/ruff/configuration/#error-suppression
2e2679e
to
ae436ac
Compare
Ha my bad, the noqa was useless as I fixed it too. |
(Removed the lock on the master branch from the setting so it could be merged) |
Shouldn't it be there? I must be missing something from Github 😕 |
Locking is locking, it means we can't merge anything. I think protection from push (you can only merge to master after a review) is what we need. |
Follow-up to #4 (can wait a new release compatible with pylint 3.0)