-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pylint in the continuous integration and pre-commit #7
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7 +/- ##
=======================================
Coverage 86.96% 86.96%
=======================================
Files 33 33
Lines 399 399
Branches 81 81
=======================================
Hits 347 347
Misses 48 48
Partials 4 4
☔ View full report in Codecov by Sentry. |
b6913ec
to
d1634fd
Compare
865b9fc
to
6619f76
Compare
idk why codecov is crying for, ignore it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have, at least, missed good-names
from the old config.
Some of those names ofc, are coming from the pylint (<3?) limitation that two-lettered variables are not acceptable (I don't remember the issue number).
Let me contemplate on the configuration? Otherwise this is solid work!
For good names everything is either the pylint default or something not required now that pylint does not raise for <3 letters variables anymore
|
b92227b
to
0816fc3
Compare
Signed-off-by: Stavros Ntentos <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest changes bring over some of the things I like. I think this is done for now, yes.
Great ! |
Follow-up to #6