Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is milksnake a runtime dependency? #188

Closed
dvzrv opened this issue Feb 8, 2022 · 2 comments · Fixed by #195 or #198
Closed

Is milksnake a runtime dependency? #188

dvzrv opened this issue Feb 8, 2022 · 2 comments · Fixed by #195 or #198

Comments

@dvzrv
Copy link
Contributor

dvzrv commented Feb 8, 2022

The setup.cfg denotes milksnake as a runtime dependency, but I believe that is very likely an error (it's used during setup, but not during runtime).

It would be great to get confirmation on this, then I can open a PR to remove it :)

@mbrossard
Copy link
Collaborator

Could you try to build the maturin branch? I am not sure I have properly connected all the pieces. I need to update GitHub Actions configuration, and setuptools_scm needs to be replaced.

@dvzrv
Copy link
Contributor Author

dvzrv commented Dec 20, 2022

milksnake is unfortunately still present in setup.cfg and will unconditionally drag it in upon installing this project.

@mbrossard mbrossard reopened this Dec 20, 2022
mbrossard added a commit that referenced this issue Dec 20, 2022
@flit flit closed this as completed in #198 Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants