pip download: make sure that --use-pep517 is propagated to the dependencies #11022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
approved these changes
Apr 12, 2022
SpecLad
force-pushed
the
download-propagate-pep517
branch
from
4ef5f44
to
d5df734
Compare
|
I realized that I could make the test run without network access, so I did that. |
uranusjr
reviewed
Apr 18, 2022
SpecLad
force-pushed
the
download-propagate-pep517
branch
from
d5df734
to
e3be557
Compare
uranusjr
approved these changes
Apr 18, 2022
SpecLad
force-pushed
the
download-propagate-pep517
branch
2 times, most recently
from
1535e42
to
539a394
Compare
|
My previous approach to testing stopped working because of #10717, so I changed the test to use a different approach. |
github-actions
bot
added
the
needs rebase or merge
The approach it uses now doesn't work anymore due to 452d7da. The installation of `fake_dep` now succeeds whether or not `setuptools` is installed in the test environment. Use a different approach instead: try to import `pip` in the `setup.py` script. If it succeeds, then we are not running in an isolated environment, and therefore PEP 517 isn't being used. To add this custom logic to `setup.py`, add a new argument to `create_basic_sdist_for_package`. Note that to make this work, I had to switch from f-strings to `str.format`, since the `dedent` has to happen before formatting.
SpecLad
force-pushed
the
download-propagate-pep517
branch
from
539a394
to
28d7730
Compare
|
Rebased to fix conflicts. |
|
Thank you @SpecLad ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9523