Allow --prefer-binary option in requirements file #7996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deveshks
force-pushed
the
add-prefer-binary-to-req-file
branch
from
7c28953
to
0afdc82
Compare
deveshks
changed the title
deveshks
force-pushed
the
add-prefer-binary-to-req-file
branch
from
0afdc82
to
6e048b2
Compare
|
Hi @pradyunsg Could you please take a look at this PR and suggest if this is the correct way of handling |
|
Can I get this PR reviewed? |
pradyunsg
reviewed
Apr 23, 2020
deveshks
force-pushed
the
add-prefer-binary-to-req-file
branch
from
444befb
to
a0c2168
Compare
|
If there are no more changes necessary to be done in this PR, may I get this merged? |
deveshks
force-pushed
the
add-prefer-binary-to-req-file
branch
from
a0c2168
to
ebf27ee
Compare
pradyunsg
added
C: requirement file
This was referenced May 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes and closes #7693 .
Adds the --prefer-binary options as a supported option in requirements.txt
Something like
I saw that the PR #5370 which introduced this behaviour had some tests. I have replicated those tests with a requirements.txt file.