DO NOT sort the returned matches by version #8319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A higher version is not always preferred over the lower; the user may be explicitly preferring lower versions by specifying --prefer-binary or similar flags. PackageFinder already takes these into account for these and orders the matches. Don't break it.
uranusjr
added
skip news
This was referenced May 25, 2020
pradyunsg
reviewed
May 25, 2020
Comment on lines
104
to
+106
| if c.is_installed and not _eligible_for_upgrade(c.name): | ||
| return (1, c.version) | ||
|
|
||
| return (0, c.version) | ||
| return 1 | ||
| return 0 |
There was a problem hiding this comment.
nit:
return int(c.is_installed and not _eligible_for_upgrade(c.name))puppy face
pradyunsg
approved these changes
May 25, 2020
|
This is likely also the fix to the currently xfail-ed |
|
I'm gonna go ahead and merge this without Paul's green tick since... I'm pretty certain that this change is good to go. (please holler if I'm wrong Paul!) |
|
Fine with me, I've been mostly offline all day (public holiday in the UK, plus attempting to take some time away from a PC screen). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug found by the unit test introduced in #7996.
A higher version is not always preferred over the lower; the user may be explicitly preferring lower versions by specifying --prefer-binary or similar flags.
PackageFinderalready takes these into account and orders the matches. Don't break it.