Remove new resolver marker from tests that should pass #8321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
added
skip news
uranusjr
force-pushed
the
new-resolver-passing-tests
branch
from
13e1b9c
to
165c41b
Compare
pradyunsg
approved these changes
May 25, 2020
pfmoore
approved these changes
May 27, 2020
|
Why has |
|
It’s added after we compiled the failing tests and has been failing since then. (Edit: I think #8319 fixed it, let me rebase this to master.) |
uranusjr
force-pushed
the
new-resolver-passing-tests
branch
from
70dcb85
to
71511af
Compare
|
Ah, cool. That's why master isn't red then :-) |
|
Come on Travis. |
|
Yay! Get it in while it's green 🙂 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base direct candidate from extras has been implemented in #8291, these should pass:
test_install_extra_mergingtest_install_local_editable_with_extrasMarker filtering has been implemented in #8239, this should pass:
test_pep518_with_extra_and_markers