Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor pip 22.0.4 follow-up changes [Diff of actual changes to code] #4969

Closed
wants to merge 34 commits into from

Conversation

matteius
Copy link
Member

@matteius matteius commented Feb 23, 2022

This is the result of many hours, debugging pip 22.0.3 working out the kinks to: #4966
However two days ago pip==22.0.4 was released and so I updated the parent branch vendoring to vendor to that, which resolved virtually all of the issues I had with 22.0.3 that lead to code changes. I've since pulled out the code changes to the minimalist most changed which are:

ALL TESTS NOW PASSING!!!

TODO

In both cases I have a workaround to the TODOs in this PR until those packages can be releases and then I can update the vendoring to include them and remove my manual changes there.

This requires dropping support for python 3.6 because pip 22.x dropped support, which should be fine since its EOL. However I recommend we do one more release of the other fixes in master before eventually doing a release that includes the pip vendoring updates.

Once the requirementslib and pipshims have new releases I can vendor the parent PR and close down this one as it won't have any extra changes required, I think.

@matteius

This comment was marked as resolved.

@matteius matteius mentioned this pull request Feb 24, 2022
@matteius matteius changed the title Vendor pip 22.0.3 follow-up changes [Diff of actual changes to code] Vendor pip 22.0.4 follow-up changes [Diff of actual changes to code] Mar 9, 2022
@matteius matteius mentioned this pull request Mar 9, 2022
2 tasks
@matteius matteius requested review from frostming and oz123 March 9, 2022 12:36
Base automatically changed from issues-4651-vendor-pip-22.0.3 to main April 19, 2022 03:48
@matteius
Copy link
Member Author

This was not needed once the vendoring of new pip-shims and requirementslib were completed.

@matteius matteius closed this Apr 20, 2022
@matteius matteius deleted the vendor-pip-22.0.3-followup-changes branch April 20, 2022 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants