Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle verbosity argument to obtain in pip 22.x + fix CI #311

Merged
merged 9 commits into from
Mar 31, 2022

Conversation

matteius
Copy link
Collaborator

@matteius matteius commented Mar 9, 2022

New version of pip requires a verbosity argument and pip-shims has already updated to support it:
sarugaku/pip-shims#79

This will support pipenv: https://github.com/pypa/pipenv/pull/4969/files

Includes cleanup to get CI passing. Notable:

  • setuptools is taking steps towards distlib removal, and so import order matters now to continue as-is.
  • Python 3.6 is dead and the test for requests master was failing, so I removed support. Noting here that the code likely still works for python 3.6, but users shouldn't expect that trend to continue.
  • Pin pyparsing < 3.0.0 to give us time to investigate two test failures related to parsing system markers in the 3.x series.

@matteius matteius changed the title Handle verbosity argument to obtain in pip 22.x Handle verbosity argument to obtain in pip 22.x + general cleanup Mar 29, 2022
@matteius matteius changed the title Handle verbosity argument to obtain in pip 22.x + general cleanup Handle verbosity argument to obtain in pip 22.x + fix CI Mar 29, 2022
@@ -41,7 +41,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: [3.6, 3.7, 3.8, 3.9, "3.10"]
python-version: [3.7, 3.8, 3.9, "3.10"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if the quotes around 3.10 are necessary. But you didn't do it, so it does not matter so much.

Copy link
Member

@frostming frostming Apr 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does, it is a common quirk of yaml, 3.10 will be parsed as 3.1(float). In fact all 3.x if not quoted, are parsed as floats, but only 3.10 changes the meaning.

@matteius matteius merged commit 5ef9418 into sarugaku:main Mar 31, 2022
@matteius matteius deleted the pip-22.x-verbosity-arg branch March 31, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants