Skip to content

Commit

Permalink
Multiple pyproject.toml fixes (#251)
Browse files Browse the repository at this point in the history
* Remove redundant wheel dep from pyproject.toml

Remove the redundant `wheel` dependency, as it is added by the backend
automatically.  Listing it explicitly in the documentation was
a historical mistake and has been fixed since, see:
pypa/setuptools@f7d30a9

Signed-off-by: Michał Górny <[email protected]>

* Remove install-time dependencies from pyproject.toml requires

Remove the install-time dependencies from pyproject.toml `requires` key.
This key is used to specify the packages that are needed to build
the wheel, and FWICS none of these packages are actually needed
throughout the run of `setup.py`.  I can also confirm that a pure venv
`python -m build -w` works fine without them.

Signed-off-by: Michał Górny <[email protected]>

* Use the non-legacy setuptools backend in pyproject.toml

Use the regular `setuptools.build_meta` backend rather than
the `__legacy__` backend.  The latter was never meant to be used
explicitly in `pyproject.toml` files but rather as implicit fallback
in tools such as pip(1).  See e.g.:
pypa/setuptools#1689

Signed-off-by: Michał Górny <[email protected]>

Co-authored-by: Dustin Ingram <[email protected]>
  • Loading branch information
mgorny and di authored Aug 7, 2022
1 parent 4f5fe3c commit 3f28634
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[build-system]
requires = ["setuptools>=40.8.0", "wheel", "bleach>=2.1.0", "docutils>=0.13.1", "Pygments>=2.5.1"]
build-backend = "setuptools.build_meta:__legacy__"
requires = ["setuptools>=40.8.0"]
build-backend = "setuptools.build_meta"

# TODO: Remove when https://github.com/mgedmin/check-manifest/pull/155 released
[tool.check-manifest]
Expand Down

0 comments on commit 3f28634

Please sign in to comment.