Multiple pyproject.toml fixes #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the redundant `wheel` dependency, as it is added by the backend automatically. Listing it explicitly in the documentation was a historical mistake and has been fixed since, see: pypa/setuptools@f7d30a9 Signed-off-by: Michał Górny <[email protected]>
Remove the install-time dependencies from pyproject.toml `requires` key. This key is used to specify the packages that are needed to build the wheel, and FWICS none of these packages are actually needed throughout the run of `setup.py`. I can also confirm that a pure venv `python -m build -w` works fine without them. Signed-off-by: Michał Górny <[email protected]>
Use the regular `setuptools.build_meta` backend rather than the `__legacy__` backend. The latter was never meant to be used explicitly in `pyproject.toml` files but rather as implicit fallback in tools such as pip(1). See e.g.: pypa/setuptools#1689 Signed-off-by: Michał Górny <[email protected]>
miketheman
approved these changes
Aug 7, 2022
There was a problem hiding this comment.
I've confirmed that the resulting requires.txt file in the package remains the same and contains the correct requirements.
This should reduce the amount of dependencies that are installed for builds - but tests will still install the requirements per the test suites.
Thanks!
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wheelrequirementrequires