Skip to content

Commit

Permalink
Bump version: 46.1.2 → 46.1.3
Browse files Browse the repository at this point in the history
  • Loading branch information
Jason R. Coombs authored and Jason R. Coombs committed Mar 25, 2020
1 parent 7e2f307 commit 3aeec3f
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .bumpversion.cfg
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[bumpversion]
current_version = 46.1.2
current_version = 46.1.3
commit = True
tag = True

Expand Down
6 changes: 6 additions & 0 deletions CHANGES.rst
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
v46.1.3
-------

No significant changes.


v46.1.2
-------

Expand Down
2 changes: 1 addition & 1 deletion setup.cfg
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ formats = zip

[metadata]
name = setuptools
version = 46.1.2
version = 46.1.3
description = Easily download, build, install, upgrade, and uninstall Python packages
author = Python Packaging Authority
author_email = [email protected]
Expand Down

8 comments on commit 3aeec3f

@webknjaz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaraco looks like you're using an email that's not connected to your GitHub account in this commit

@jaraco
Copy link
Member

@jaraco jaraco commented on 3aeec3f Apr 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that the logo is missing, but I can't seem to tell what e-mail was used by looking at the GitHub UI.

@jaraco
Copy link
Member

@jaraco jaraco commented on 3aeec3f Apr 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing happened with v46.1.2. It's using the local hostname for the git commit. I suspect something has changed with bump2version or it's due to the tox -e finalize approach.

@jaraco
Copy link
Member

@jaraco jaraco commented on 3aeec3f Apr 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, because tox suppresses environment variables by default, and because HOME isn't defined, ~/.gitconfig won't be honored.

@webknjaz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, by default, git should pick up your global settings from ~/.gitconfig, then repo-local from .git/config in the repo. That is if the env vars are passed forbidding it to do so.

@webknjaz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(GIT_CONFIG_NOGLOBAL=1/GIT_CONFIG_NOSYSTEM=1)

@webknjaz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's also a --system location /etc/gitconfig if you're up to it

@jaraco
Copy link
Member

@jaraco jaraco commented on 3aeec3f Apr 6, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed #2057

Please sign in to comment.