Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tox -e finalize operates without git config #2057

Closed
jaraco opened this issue Apr 6, 2020 · 2 comments
Closed

tox -e finalize operates without git config #2057

jaraco opened this issue Apr 6, 2020 · 2 comments

Comments

@jaraco
Copy link
Member

jaraco commented Apr 6, 2020

In 3aeec3f, @webknjaz observed that the tagged releases are being tagged by a local address and not a proper e-mail address.

Likely cause is that tox -e finalize suppresses the HOME environment variable and thus settings in ~/.gitconfig aren't honored.
jaraco referenced this issue Apr 6, 2020
Bump version: 46.1.2 → 46.1.3
3aeec3f
@webknjaz
Copy link
Member

webknjaz commented Apr 6, 2020

HOME environment variable

Or XDG_CONFIG_HOME

@webknjaz
Copy link
Member

webknjaz commented Apr 6, 2020

Could also set GIT_AUTHOR_EMAIL / GIT_COMMITTER_EMAIL: https://git-scm.com/book/en/v2/Git-Internals-Environment-Variables.

jaraco added a commit that referenced this issue Apr 6, 2020
@jaraco
Protect against situation where the Git user e-mail is not configured…
03b92ca 
…. Ref #2057.
@jaraco jaraco closed this as completed in 53c284b Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jaraco @webknjaz