[WIP] Project reservations #12527
Closed
[WIP] Project reservations #12527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
woodruffw
commented
Nov 10, 2022
Comment on lines
+200
to
+204
| return ( | ||
| self.has_primary_verified_email | ||
| and self.has_two_factor | ||
| and self.date_joined <= ninety_days_ago | ||
| and not has_already_reserved_project |
There was a problem hiding this comment.
Flagging for review: do I need to check User.is_frozen here as well? I don't think I do since I believe that frozen users can't log in to begin with, but I could be wrong about that.
Reservations actually work, events are emitted, etc. Signed-off-by: William Woodruff <[email protected]>
Just making a note for myself: this'll go under |
Also add a TODO and a sanity check. Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
This handles cascades correctly, preventing FK errors when the project's events are orphaned. Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
|
@woodruffw Whatever is easiest for you! |
|
(I'll leave this branch undeleted, since I think the groundwork here might be interesting/useful if the project reservation idea is ever revived.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still a WIP; just putting something up for visibility and early feedback.
Outstanding items:
POSTing the reservation form should actually reserve the project namemanage/projectslist should include a "reserved" chip on any reserved project(s)Project.reserved_until, if presentCloses #11296.
cc @di